Unverified 提交 8b9a1cba authored 作者: Ryan Groch's avatar Ryan Groch 提交者: GitHub

Add Missing Dyad Logo (#2404)

Closes #585. Currently, there are at least two places where an Electron logo appears instead of the Dyad logo: - In the Windows control panel (see #585). - On the taskbar (or equivalent) of some Linux desktop environments while running the app. The Windows installer (`.Setup.exe`) also shows a generic icon instead of the Dyad logo when viewed in the file explorer. This PR aims to fix all of the above. It's a relatively minor detail, but it's nice to have anyway. The relevant documentation from Electron Forge is on this page: https://www.electronforge.io/guides/create-and-add-icons#setting-the-app-icon I've double-checked that this fixes the icons on Windows 10, XFCE and Cinnamon (on Linux Mint), and GNOME (on Fedora). I don't have a device that runs Windows 11. <!-- devin-review-badge-begin --> --- <a href="https://app.devin.ai/review/dyad-sh/dyad/pull/2404"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a> <!-- devin-review-badge-end --> <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Replace generic/Electron icons with the Dyad logo across Windows and Linux. Ensures correct branding in the Windows control panel, Linux taskbar, and the Windows installer. - **Bug Fixes** - Set BrowserWindow icon to assets/icon/logo.png. - Configured Electron Forge makers: - Squirrel: iconUrl and setupIcon set to Dyad .ico for installer and control panel. - Deb/RPM: icon set to Dyad .png for desktop environments. - Verified on Windows 10, Linux Mint (XFCE, Cinnamon), and Fedora (GNOME). <sup>Written for commit 2f29dcc2fd34fdc53fb9bd2126cf02a7bd719920. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --------- Co-authored-by: 's avatargemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
上级 ae996d99
...@@ -96,14 +96,26 @@ const config: ForgeConfig = { ...@@ -96,14 +96,26 @@ const config: ForgeConfig = {
isGitHubActions isGitHubActions
? { ? {
windowsSign, windowsSign,
iconUrl:
"https://raw.githubusercontent.com/dyad-sh/dyad/main/assets/icon/logo.ico",
setupIcon: "./assets/icon/logo.ico",
} }
: {}, : {
iconUrl:
"https://raw.githubusercontent.com/dyad-sh/dyad/main/assets/icon/logo.ico",
setupIcon: "./assets/icon/logo.ico",
},
), ),
new MakerZIP({}, ["darwin"]), new MakerZIP({}, ["darwin"]),
new MakerRpm({}), new MakerRpm({
options: {
icon: "./assets/icon/logo.png",
},
}),
new MakerDeb({ new MakerDeb({
options: { options: {
mimeType: ["x-scheme-handler/dyad"], mimeType: ["x-scheme-handler/dyad"],
icon: "./assets/icon/logo.png",
}, },
}), }),
new MakerAppImage({ new MakerAppImage({
......
...@@ -211,6 +211,7 @@ const createWindow = () => { ...@@ -211,6 +211,7 @@ const createWindow = () => {
preload: path.join(__dirname, "preload.js"), preload: path.join(__dirname, "preload.js"),
// transparent: true, // transparent: true,
}, },
icon: path.join(app.getAppPath(), "assets/icon/logo.png"),
// backgroundColor: "#00000001", // backgroundColor: "#00000001",
// frame: false, // frame: false,
}); });
......
Markdown 格式
0%
您添加了 0 到此讨论。请谨慎行事。
请先完成此评论的编辑!
注册 或者 后发表评论