Unverified 提交 ae996d99 authored 作者: Will Chen's avatar Will Chen 提交者: GitHub

Fix Windows signing failure caused by UTF-8 BOM in metadata JSON (#2446)

## Summary - Windows release builds fail during code signing because the Azure Trusted Signing DLL cannot parse the signing metadata JSON file - The `signing-metadata.json` is written with a UTF-8 BOM (0xEF 0xBB 0xBF) by Windows PowerShell 5.1's `Out-File -Encoding utf8`, and .NET's `System.Text.Json` parser rejects the BOM as invalid JSON - Fix: switch `shell: powershell` to `shell: pwsh` (PowerShell Core) which writes UTF-8 without BOM by default ## Test plan - Re-run the release workflow and verify the Windows build completes signing successfully #skip-bugbot 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- devin-review-badge-begin --> --- <a href="https://app.devin.ai/review/dyad-sh/dyad/pull/2446"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a> <!-- devin-review-badge-end --> <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fix Windows release signing failures by switching the workflow to PowerShell Core (pwsh) so signing-metadata.json is written as UTF-8 without a BOM. This avoids the .NET System.Text.Json BOM error and lets Azure Trusted Signing parse the file successfully. <sup>Written for commit b1967255ec4547681dd5650fe0c2154b7374f0ad. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> Co-authored-by: 's avatarClaude Opus 4.5 <noreply@anthropic.com>
上级 f0ae4e98
...@@ -104,7 +104,7 @@ jobs: ...@@ -104,7 +104,7 @@ jobs:
- name: Create Azure signing metadata - name: Create Azure signing metadata
if: contains(matrix.os.name, 'windows') if: contains(matrix.os.name, 'windows')
shell: powershell shell: pwsh
run: | run: |
@' @'
{ {
......
Markdown 格式
0%
您添加了 0 到此讨论。请谨慎行事。
请先完成此评论的编辑!
注册 或者 后发表评论