• Will Chen's avatar
    fix(e2e): use correct page object sub-components in createGitConflict helper (#2604) · 552a705d
    Will Chen 提交于
    ## Summary
    - Fixed 4 TypeScript errors in `e2e-tests/git_collaboration.spec.ts`
    where the `createGitConflict` helper called
    `getTitleBarAppNameButton()`, `getCurrentAppPath()`, and `goToChatTab()`
    directly on `po` instead of through `po.appManagement` and
    `po.navigation`
    - Added PageObject sub-component pattern documentation to
    `rules/e2e-testing.md`
    
    ## Test plan
    - `npm run ts` passes with zero errors
    - All 784 unit tests pass
    
    🤖 Generated with [Claude Code](https://claude.com/claude-code)
    <!-- devin-review-badge-begin -->
    
    ---
    
    <a href="https://app.devin.ai/review/dyad-sh/dyad/pull/2604"
    target="_blank">
      <picture>
    <source media="(prefers-color-scheme: dark)"
    srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1">
    <img
    src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1"
    alt="Open with Devin">
      </picture>
    </a>
    <!-- devin-review-badge-end -->
    
    <!-- CURSOR_SUMMARY -->
    ---
    
    > [!NOTE]
    > **Low Risk**
    > E2E test refactor plus documentation only; no production logic
    changes, with minimal risk beyond potential test behavior differences if
    selectors were misrouted.
    > 
    > **Overview**
    > Updates `createGitConflict` in `e2e-tests/git_collaboration.spec.ts`
    to call UI helpers through the correct `PageObject` sub-components
    (e.g., `po.appManagement.*`, `po.navigation.*`) instead of nonexistent
    top-level `po` methods, resolving TypeScript errors.
    > 
    > Adds documentation to `rules/e2e-testing.md` describing the
    `PageObject` sub-component pattern and listing the primary
    sub-components to use in E2E tests.
    > 
    > <sup>Written by [Cursor
    Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
    c053dacf656833ad274881e97337f8a97c97f1ee. This will update automatically
    on new commits. Configure
    [here](https://cursor.com/dashboard?tab=bugbot).</sup>
    <!-- /CURSOR_SUMMARY -->
    
    <!-- This is an auto-generated description by cubic. -->
    ---
    ## Summary by cubic
    Fixed TypeScript errors in the createGitConflict e2e helper by using the
    correct PageObject sub-components (po.appManagement and po.navigation).
    Added docs in e2e-testing.md explaining the PageObject sub-component
    pattern to prevent calling methods directly on po.
    
    <sup>Written for commit c053dacf656833ad274881e97337f8a97c97f1ee.
    Summary will update on new commits.</sup>
    
    <!-- End of auto-generated description by cubic. -->
    Co-authored-by: 's avatarClaude Opus 4.6 <noreply@anthropic.com>
    552a705d
e2e-testing.md 4.5 KB