• Will Chen's avatar
    fix(e2e): use correct page object sub-components in createGitConflict helper (#2604) · 552a705d
    Will Chen 提交于
    ## Summary
    - Fixed 4 TypeScript errors in `e2e-tests/git_collaboration.spec.ts`
    where the `createGitConflict` helper called
    `getTitleBarAppNameButton()`, `getCurrentAppPath()`, and `goToChatTab()`
    directly on `po` instead of through `po.appManagement` and
    `po.navigation`
    - Added PageObject sub-component pattern documentation to
    `rules/e2e-testing.md`
    
    ## Test plan
    - `npm run ts` passes with zero errors
    - All 784 unit tests pass
    
    🤖 Generated with [Claude Code](https://claude.com/claude-code)
    <!-- devin-review-badge-begin -->
    
    ---
    
    <a href="https://app.devin.ai/review/dyad-sh/dyad/pull/2604"
    target="_blank">
      <picture>
    <source media="(prefers-color-scheme: dark)"
    srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1">
    <img
    src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1"
    alt="Open with Devin">
      </picture>
    </a>
    <!-- devin-review-badge-end -->
    
    <!-- CURSOR_SUMMARY -->
    ---
    
    > [!NOTE]
    > **Low Risk**
    > E2E test refactor plus documentation only; no production logic
    changes, with minimal risk beyond potential test behavior differences if
    selectors were misrouted.
    > 
    > **Overview**
    > Updates `createGitConflict` in `e2e-tests/git_collaboration.spec.ts`
    to call UI helpers through the correct `PageObject` sub-components
    (e.g., `po.appManagement.*`, `po.navigation.*`) instead of nonexistent
    top-level `po` methods, resolving TypeScript errors.
    > 
    > Adds documentation to `rules/e2e-testing.md` describing the
    `PageObject` sub-component pattern and listing the primary
    sub-components to use in E2E tests.
    > 
    > <sup>Written by [Cursor
    Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
    c053dacf656833ad274881e97337f8a97c97f1ee. This will update automatically
    on new commits. Configure
    [here](https://cursor.com/dashboard?tab=bugbot).</sup>
    <!-- /CURSOR_SUMMARY -->
    
    <!-- This is an auto-generated description by cubic. -->
    ---
    ## Summary by cubic
    Fixed TypeScript errors in the createGitConflict e2e helper by using the
    correct PageObject sub-components (po.appManagement and po.navigation).
    Added docs in e2e-testing.md explaining the PageObject sub-component
    pattern to prevent calling methods directly on po.
    
    <sup>Written for commit c053dacf656833ad274881e97337f8a97c97f1ee.
    Summary will update on new commits.</sup>
    
    <!-- End of auto-generated description by cubic. -->
    Co-authored-by: 's avatarClaude Opus 4.6 <noreply@anthropic.com>
    552a705d
名称
最后提交
最后更新
.claude 正在载入提交数据...
.cursor/rules 正在载入提交数据...
.devcontainer 正在载入提交数据...
.github 正在载入提交数据...
.husky 正在载入提交数据...
.storybook 正在载入提交数据...
assets 正在载入提交数据...
docs 正在载入提交数据...
drizzle 正在载入提交数据...
e2e-tests 正在载入提交数据...
makers 正在载入提交数据...
packages/@dyad-sh 正在载入提交数据...
rules 正在载入提交数据...
scaffold 正在载入提交数据...
scripts 正在载入提交数据...
shared 正在载入提交数据...
src 正在载入提交数据...
testing 正在载入提交数据...
tools 正在载入提交数据...
worker 正在载入提交数据...
workers/tsc 正在载入提交数据...
.cursorignore 正在载入提交数据...
.env.example 正在载入提交数据...
.eslintrc.json 正在载入提交数据...
.gitattributes 正在载入提交数据...
.gitignore 正在载入提交数据...
.oxfmtrc.json 正在载入提交数据...
.oxlintrc.json 正在载入提交数据...
.prettierignore 正在载入提交数据...
.prettierrc 正在载入提交数据...
AGENTS.md 正在载入提交数据...
CLA.md 正在载入提交数据...
CLAUDE.md 正在载入提交数据...
CONTRIBUTING.md 正在载入提交数据...
LICENSE 正在载入提交数据...
README.md 正在载入提交数据...
SECURITY.md 正在载入提交数据...
biome.json 正在载入提交数据...
components.json 正在载入提交数据...
drizzle.config.ts 正在载入提交数据...
forge.config.ts 正在载入提交数据...
forge.env.d.ts 正在载入提交数据...
index.html 正在载入提交数据...
lint-staged.config.js 正在载入提交数据...
merge.config.ts 正在载入提交数据...
package-lock.json 正在载入提交数据...
package.json 正在载入提交数据...
playwright.config.ts 正在载入提交数据...
tsconfig.app.json 正在载入提交数据...
tsconfig.json 正在载入提交数据...
tsconfig.node.json 正在载入提交数据...
vite.main.config.mts 正在载入提交数据...
vite.preload.config.mts 正在载入提交数据...
vite.renderer.config.mts 正在载入提交数据...
vite.worker.config.mts 正在载入提交数据...
vitest.config.ts 正在载入提交数据...
windowsSign.ts 正在载入提交数据...