• wwwillchen-bot's avatar
    refactor: expose PageObject component page objects publicly (#2582) · dcf06ece
    wwwillchen-bot 提交于
    ## Summary
    - Updated PageObject class to expose component page objects
    (chatActions, previewPanel, codeEditor, etc.) as public properties
    instead of private
    - Updated all e2e spec files to use explicit component access pattern
    (e.g., `po.chatActions.sendPrompt()` instead of `po.sendPrompt()`)
    - Makes the test code more modular and explicit about which component is
    being used
    
    ## Test plan
    - [x] All 784 unit tests pass
    - [x] TypeScript type checking passes
    - [x] Linting passes
    - [ ] E2E tests should be run via CI
    
    🤖 Generated with [Claude Code](https://claude.com/claude-code)
    <!-- devin-review-badge-begin -->
    
    ---
    
    <a href="https://app.devin.ai/review/dyad-sh/dyad/pull/2582"
    target="_blank">
      <picture>
    <source media="(prefers-color-scheme: dark)"
    srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1">
    <img
    src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1"
    alt="Open with Devin">
      </picture>
    </a>
    <!-- devin-review-badge-end -->
    
    <!-- This is an auto-generated description by cubic. -->
    ---
    ## Summary by cubic
    Refactored the e2e PageObject to expose component objects publicly and
    added delegated helpers (sendPrompt, importApp) for shorter calls. Tests
    now use explicit component access with shorthand for common actions,
    making code clearer and easier to maintain.
    
    - **Refactors**
    - Exposed component objects on PageObject (chatActions, previewPanel,
    codeEditor, modelPicker, settings, navigation, toastNotifications,
    appManagement, securityReview, agentConsent, githubConnector).
    - Added PageObject.sendPrompt() and PageObject.importApp() delegates;
    updated specs to use them for brevity.
    - Removed monolithic wrappers; no functional app changes—test-only
    refactor.
    
    - **Migration**
    - Use component methods directly (e.g.,
    po.previewPanel.selectPreviewMode(), po.settings.recordSettings(),
    po.toastNotifications.waitForToastWithText()).
    - Prefer po.sendPrompt() and po.importApp() for common actions; replace
    old PageObject methods with component or delegate equivalents.
    
    <sup>Written for commit 15cf1998d7f9b06e0fe6e53f8cc36f4f3c42e630.
    Summary will update on new commits.</sup>
    
    <!-- End of auto-generated description by cubic. -->
    
    ---------
    Co-authored-by: 's avatarWill Chen <willchen90@gmail.com>
    Co-authored-by: 's avatarClaude Opus 4.5 <noreply@anthropic.com>
    dcf06ece
名称
最后提交
最后更新
.claude 正在载入提交数据...
.cursor/rules 正在载入提交数据...
.devcontainer 正在载入提交数据...
.github 正在载入提交数据...
.husky 正在载入提交数据...
.storybook 正在载入提交数据...
assets 正在载入提交数据...
docs 正在载入提交数据...
drizzle 正在载入提交数据...
e2e-tests 正在载入提交数据...
makers 正在载入提交数据...
packages/@dyad-sh 正在载入提交数据...
rules 正在载入提交数据...
scaffold 正在载入提交数据...
scripts 正在载入提交数据...
shared 正在载入提交数据...
src 正在载入提交数据...
testing 正在载入提交数据...
tools 正在载入提交数据...
worker 正在载入提交数据...
workers/tsc 正在载入提交数据...
.cursorignore 正在载入提交数据...
.env.example 正在载入提交数据...
.eslintrc.json 正在载入提交数据...
.gitattributes 正在载入提交数据...
.gitignore 正在载入提交数据...
.oxfmtrc.json 正在载入提交数据...
.oxlintrc.json 正在载入提交数据...
.prettierignore 正在载入提交数据...
.prettierrc 正在载入提交数据...
AGENTS.md 正在载入提交数据...
CLA.md 正在载入提交数据...
CLAUDE.md 正在载入提交数据...
CONTRIBUTING.md 正在载入提交数据...
LICENSE 正在载入提交数据...
README.md 正在载入提交数据...
SECURITY.md 正在载入提交数据...
biome.json 正在载入提交数据...
components.json 正在载入提交数据...
drizzle.config.ts 正在载入提交数据...
forge.config.ts 正在载入提交数据...
forge.env.d.ts 正在载入提交数据...
index.html 正在载入提交数据...
lint-staged.config.js 正在载入提交数据...
merge.config.ts 正在载入提交数据...
package-lock.json 正在载入提交数据...
package.json 正在载入提交数据...
playwright.config.ts 正在载入提交数据...
tsconfig.app.json 正在载入提交数据...
tsconfig.json 正在载入提交数据...
tsconfig.node.json 正在载入提交数据...
vite.main.config.mts 正在载入提交数据...
vite.preload.config.mts 正在载入提交数据...
vite.renderer.config.mts 正在载入提交数据...
vite.worker.config.mts 正在载入提交数据...
vitest.config.ts 正在载入提交数据...
windowsSign.ts 正在载入提交数据...