• Will Chen's avatar
    Move remember-learnings to beginning of pr-push workflow (#2485) · 98c169b9
    Will Chen 提交于
    ## Summary
    Reordered the `/dyad:pr-push` command workflow to run the
    `remember-learnings` skill before lint checks, rather than after. This
    ensures that learnings are captured early in the process and included in
    the final commit.
    
    ## Changes
    - **Workflow reordering**: Moved the "Remember learnings" step from
    position 6 to position 3 (before lint checks)
    - This allows `AGENTS.md` changes to be captured before any
    formatting/linting modifications
    - Ensures learnings are part of the final amended commit rather than
    added after lint changes
      
    - **Updated step numbering**: Renumbered all subsequent steps (lint
    checks, tests, and final push) to reflect the new order
    
    - **Updated command metadata**: Added `remember-learnings` as a
    dependent skill in the pr-push command documentation
    
    - **Simplified git logic**: Removed the conditional guard comment since
    the step now runs earlier in the process
    
    ## Rationale
    By capturing learnings before lint checks, we ensure that:
    1. All insights from the session are preserved in `AGENTS.md`
    2. The file is included in the commit before any auto-formatting occurs
    3. The final commit contains both learnings and properly formatted code
    4. There's no risk of learnings being lost if lint makes significant
    changes
    
    https://claude.ai/code/session_01KfNBDK6GsBNu2zD85UfA7V
    <!-- devin-review-badge-begin -->
    
    ---
    
    <a href="https://app.devin.ai/review/dyad-sh/dyad/pull/2485">
      <picture>
    <source media="(prefers-color-scheme: dark)"
    srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1">
    <img
    src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1"
    alt="Open with Devin">
      </picture>
    </a>
    <!-- devin-review-badge-end -->
    
    
    <!-- This is an auto-generated description by cubic. -->
    ---
    ## Summary by cubic
    Moved the remember-learnings step to run before linting in the
    /dyad:pr-push workflow so AGENTS.md updates are captured early and
    included in the commit. This prevents learnings from being lost and
    keeps the final commit consistent.
    
    - **Refactors**
    - Run remember-learnings at step 3 (before lint/formatting); renumbered
    following steps.
    - Stage AGENTS.md and amend the last commit when changed, ensuring
    learnings land before lint changes.
    - Updated README and pr-push docs to reflect the new dependency and step
    order.
    
    <sup>Written for commit d010420a889a8cbf896511199f926f066a62fd35.
    Summary will update on new commits.</sup>
    
    <!-- End of auto-generated description by cubic. -->
    
    <!-- CURSOR_SUMMARY -->
    ---
    
    > [!NOTE]
    > **Low Risk**
    > Low risk documentation-only change that reorders the `pr-push`
    checklist; no runtime code, build, or security-sensitive logic is
    modified.
    > 
    > **Overview**
    > Updates the `/dyad:pr-push` workflow to run `remember-learnings`
    *before* linting, with instructions to stage `AGENTS.md` and amend the
    latest commit so learnings are captured early.
    > 
    > Renumbers the remaining steps accordingly and updates
    `.claude/README.md` to list `remember-learnings` as a dependency for
    `/dyad:pr-push`.
    > 
    > <sup>Written by [Cursor
    Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
    d010420a889a8cbf896511199f926f066a62fd35. This will update automatically
    on new commits. Configure
    [here](https://cursor.com/dashboard?tab=bugbot).</sup>
    <!-- /CURSOR_SUMMARY -->
    Co-authored-by: 's avatarClaude <noreply@anthropic.com>
    98c169b9
名称
最后提交
最后更新
.claude 正在载入提交数据...
.cursor/rules 正在载入提交数据...
.devcontainer 正在载入提交数据...
.github 正在载入提交数据...
.husky 正在载入提交数据...
assets 正在载入提交数据...
docs 正在载入提交数据...
drizzle 正在载入提交数据...
e2e-tests 正在载入提交数据...
makers 正在载入提交数据...
packages/@dyad-sh 正在载入提交数据...
scaffold 正在载入提交数据...
scripts 正在载入提交数据...
shared 正在载入提交数据...
src 正在载入提交数据...
testing 正在载入提交数据...
tools 正在载入提交数据...
worker 正在载入提交数据...
workers/tsc 正在载入提交数据...
.cursorignore 正在载入提交数据...
.env.example 正在载入提交数据...
.eslintrc.json 正在载入提交数据...
.gitattributes 正在载入提交数据...
.gitignore 正在载入提交数据...
.oxfmtrc.json 正在载入提交数据...
.oxlintrc.json 正在载入提交数据...
.prettierignore 正在载入提交数据...
.prettierrc 正在载入提交数据...
AGENTS.md 正在载入提交数据...
CLA.md 正在载入提交数据...
CLAUDE.md 正在载入提交数据...
CONTRIBUTING.md 正在载入提交数据...
LICENSE 正在载入提交数据...
README.md 正在载入提交数据...
SECURITY.md 正在载入提交数据...
biome.json 正在载入提交数据...
components.json 正在载入提交数据...
drizzle.config.ts 正在载入提交数据...
forge.config.ts 正在载入提交数据...
forge.env.d.ts 正在载入提交数据...
index.html 正在载入提交数据...
lint-staged.config.js 正在载入提交数据...
merge.config.ts 正在载入提交数据...
package-lock.json 正在载入提交数据...
package.json 正在载入提交数据...
playwright.config.ts 正在载入提交数据...
tsconfig.app.json 正在载入提交数据...
tsconfig.json 正在载入提交数据...
tsconfig.node.json 正在载入提交数据...
vite.main.config.mts 正在载入提交数据...
vite.preload.config.mts 正在载入提交数据...
vite.renderer.config.mts 正在载入提交数据...
vite.worker.config.mts 正在载入提交数据...
vitest.config.ts 正在载入提交数据...
windowsSign.ts 正在载入提交数据...