• Will Chen's avatar
    Improve swarm PR review to detect dead infrastructure (#2529) · 7a173b21
    Will Chen 提交于
    ## Summary
    - Updated the code health reviewer role to explicitly check for **dead
    infrastructure**: DB migrations creating unused tables, API endpoints
    with no callers, config entries nothing references
    - Added cross-referencing guidance to the teammate prompt template so
    all reviewers verify schema/infra changes against actual code usage
    
    ## Context
    During review of PR #2370, the swarm review missed that a `plans` DB
    table migration was created but the implementation used file-based
    storage instead. This update ensures future reviews catch such
    mismatches.
    
    ## Test plan
    - [x] No code changes, only `.claude/skills/` markdown files updated
    - [x] Lint, type checks, and all 784 tests pass
    
    #skip-bugbot
    
    🤖 Generated with [Claude Code](https://claude.com/claude-code)
    <!-- devin-review-badge-begin -->
    
    ---
    
    <a href="https://app.devin.ai/review/dyad-sh/dyad/pull/2529"
    target="_blank">
      <picture>
    <source media="(prefers-color-scheme: dark)"
    srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1">
    <img
    src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1"
    alt="Open with Devin">
      </picture>
    </a>
    <!-- devin-review-badge-end -->
    
    <!-- This is an auto-generated description by cubic. -->
    ---
    ## Summary by cubic
    Improves the swarm PR review to catch dead infrastructure by adding
    explicit checks and cross-referencing of schema/API/config changes
    against actual usage. Prevents misses like unused DB tables by updating
    reviewer roles, prompts, and enabling agent teams.
    
    - **New Features**
    - Added dead infrastructure checks to the code health reviewer (DB
    migrations, endpoints, configs) with severity guidance.
    - Added a standardized swarm review skill (SKILL.md + role refs) and
    updated prompts to enforce cross-referencing against code usage.
    - Enabled agent teams via settings
    (CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS=1); no runtime code changes.
    
    <sup>Written for commit 78e829037cc0bc66382502b25092184f5d8f05ae.
    Summary will update on new commits.</sup>
    
    <!-- End of auto-generated description by cubic. -->
    
    ---------
    Co-authored-by: 's avatarClaude Opus 4.6 <noreply@anthropic.com>
    7a173b21
名称
最后提交
最后更新
.claude 正在载入提交数据...
.cursor/rules 正在载入提交数据...
.devcontainer 正在载入提交数据...
.github 正在载入提交数据...
.husky 正在载入提交数据...
.storybook 正在载入提交数据...
assets 正在载入提交数据...
docs 正在载入提交数据...
drizzle 正在载入提交数据...
e2e-tests 正在载入提交数据...
makers 正在载入提交数据...
packages/@dyad-sh 正在载入提交数据...
scaffold 正在载入提交数据...
scripts 正在载入提交数据...
shared 正在载入提交数据...
src 正在载入提交数据...
testing 正在载入提交数据...
tools 正在载入提交数据...
worker 正在载入提交数据...
workers/tsc 正在载入提交数据...
.cursorignore 正在载入提交数据...
.env.example 正在载入提交数据...
.eslintrc.json 正在载入提交数据...
.gitattributes 正在载入提交数据...
.gitignore 正在载入提交数据...
.oxfmtrc.json 正在载入提交数据...
.oxlintrc.json 正在载入提交数据...
.prettierignore 正在载入提交数据...
.prettierrc 正在载入提交数据...
AGENTS.md 正在载入提交数据...
CLA.md 正在载入提交数据...
CLAUDE.md 正在载入提交数据...
CONTRIBUTING.md 正在载入提交数据...
LICENSE 正在载入提交数据...
README.md 正在载入提交数据...
SECURITY.md 正在载入提交数据...
biome.json 正在载入提交数据...
components.json 正在载入提交数据...
drizzle.config.ts 正在载入提交数据...
forge.config.ts 正在载入提交数据...
forge.env.d.ts 正在载入提交数据...
index.html 正在载入提交数据...
lint-staged.config.js 正在载入提交数据...
merge.config.ts 正在载入提交数据...
package-lock.json 正在载入提交数据...
package.json 正在载入提交数据...
playwright.config.ts 正在载入提交数据...
tsconfig.app.json 正在载入提交数据...
tsconfig.json 正在载入提交数据...
tsconfig.node.json 正在载入提交数据...
vite.main.config.mts 正在载入提交数据...
vite.preload.config.mts 正在载入提交数据...
vite.renderer.config.mts 正在载入提交数据...
vite.worker.config.mts 正在载入提交数据...
vitest.config.ts 正在载入提交数据...
windowsSign.ts 正在载入提交数据...