• Mohamed Aziz Mejri's avatar
    Disable send button while approval is pending (#1368) · 582793eb
    Mohamed Aziz Mejri 提交于
    Fixes #912 
    
    This PR implements disabling send button while approval is pending and
    addresses issue #912
        
    <!-- This is an auto-generated description by cubic. -->
    ---
    
    ## Summary by cubic
    Disable the chat send button while a proposal is awaiting approval, and
    re-enable it after approve or reject. Prevents accidental messages
    during pending changes. Addresses issue #912.
    
    - **New Features**
    - Track pending changes with isChangesPending based on the last
    assistant message’s approvalState.
    - Disable the send button when a proposal is pending (in addition to the
    existing empty input check).
    - Re-enable after approve/reject by refreshing the proposal and
    messages.
      - Added Playwright e2e tests for both approve and reject flows.
    
    <!-- End of auto-generated description by cubic. -->
    
    <!-- CURSOR_SUMMARY -->
    ---
    
    > [!NOTE]
    > Disable the chat send button when a code proposal is pending approval
    and re-enable after approve/reject; add e2e coverage and update MCP
    flow.
    > 
    > - **Frontend**
    > - `ChatInput.tsx`: Read `messages` from `chatMessagesAtom` and derive
    `disableSendButton` when the last assistant message (matching
    `proposal.messageId`) has no `approvalState` and `proposal.type ===
    "code-proposal"`.
    > - Apply `disableSendButton` to the send button’s `disabled` condition
    (in addition to empty input/attachments).
    >   - Ensure proposal/messages refresh after approve/reject.
    > - **Tests**
    > - Add Playwright tests `e2e-tests/chat_input.spec.ts` to verify send
    button disabled during pending proposal and re-enabled after approve or
    reject.
    > - Update `e2e-tests/mcp.spec.ts` to click "Approve" after granting
    consent.
    > 
    > <sup>Written by [Cursor
    Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
    b9b47bd6f547449cc5cf1d39a00e4e7fb5de1bcd. This will update automatically
    on new commits. Configure
    [here](https://cursor.com/dashboard?tab=bugbot).</sup>
    <!-- /CURSOR_SUMMARY -->
    
    ---------
    Co-authored-by: 's avatarWill Chen <willchen90@gmail.com>
    582793eb
名称
最后提交
最后更新
..
fixtures 正在载入提交数据...
helpers 正在载入提交数据...
snapshots 正在载入提交数据...
1.spec.ts 正在载入提交数据...
app_search.spec.ts 正在载入提交数据...
approve.spec.ts 正在载入提交数据...
astro.spec.ts 正在载入提交数据...
attach_image.spec.ts 正在载入提交数据...
auto_approve.spec.ts 正在载入提交数据...
auto_update.spec.ts 正在载入提交数据...
azure_provider_settings.spec.ts 正在载入提交数据...
azure_send_message.spec.ts 正在载入提交数据...
backup.spec.ts 正在载入提交数据...
capacitor.spec.ts 正在载入提交数据...
chat_input.spec.ts 正在载入提交数据...
chat_mode.spec.ts 正在载入提交数据...
chat_search.spec.ts 正在载入提交数据...
context_manage.spec.ts 正在载入提交数据...
context_window.spec.ts 正在载入提交数据...
copy_app.spec.ts 正在载入提交数据...
copy_chat.spec.ts 正在载入提交数据...
delete_app.spec.ts 正在载入提交数据...
delete_provider.spec.ts 正在载入提交数据...
dump_messages.spec.ts 正在载入提交数据...
dyad_tags_parsing.spec.ts 正在载入提交数据...
edit_code.spec.ts 正在载入提交数据...
edit_custom_models.spec.ts 正在载入提交数据...
edit_provider.spec.ts 正在载入提交数据...
engine.spec.ts 正在载入提交数据...
env_var.spec.ts 正在载入提交数据...
fix_error.spec.ts 正在载入提交数据...
gateway.spec.ts 正在载入提交数据...
github.spec.ts 正在载入提交数据...
import.spec.ts 正在载入提交数据...
lm_studio.spec.ts 正在载入提交数据...
main.spec.ts 正在载入提交数据...
mcp.spec.ts 正在载入提交数据...
mention_app.spec.ts 正在载入提交数据...
new_chat.spec.ts 正在载入提交数据...
ollama.spec.ts 正在载入提交数据...
partial_response.spec.ts 正在载入提交数据...
preview_iframe.spec.ts 正在载入提交数据...
problems.spec.ts 正在载入提交数据...
prompt_library.spec.ts 正在载入提交数据...
rebuild.spec.ts 正在载入提交数据...
refresh.spec.ts 正在载入提交数据...
reject.spec.ts 正在载入提交数据...
release_channel.spec.ts 正在载入提交数据...
rename_app.spec.ts 正在载入提交数据...
rename_edit.spec.ts 正在载入提交数据...
restart.spec.ts 正在载入提交数据...
retry.spec.ts 正在载入提交数据...
select_component.spec.ts 正在载入提交数据...
setup.spec.ts 正在载入提交数据...
smart_context_options.spec.ts 正在载入提交数据...
supabase_client.spec.ts 正在载入提交数据...
supabase_migrations.spec.ts 正在载入提交数据...
supabase_stale_ui.spec.ts 正在载入提交数据...
switch_apps.spec.ts 正在载入提交数据...
switch_versions.spec.ts 正在载入提交数据...
telemetry.spec.ts 正在载入提交数据...
template-community.spec.ts 正在载入提交数据...
template-create-nextjs.spec.ts 正在载入提交数据...
thinking_budget.spec.ts 正在载入提交数据...
undo.spec.ts 正在载入提交数据...
version_integrity.spec.ts 正在载入提交数据...