docs: fix inaccuracies in rule files from weekly review (#3271)

## Summary Addresses the two "needs update" items from the weekly rules review in #3238: - **`rules/openai-reasoning-models.md`**: Replace reference to non-existent `filterOrphanedReasoningParts()` with the actual function `cleanMessage()` in `src/ipc/utils/ai_messages_utils.ts`. - **`rules/chat-message-indicators.md`**: Replace `"in-progress"` with `"pending"` to match the actual `CustomTagState` type (`"pending" | "finished" | "aborted"`) defined in `src/components/chat/stateTypes.ts`. Closes #3238. ## Test plan - [x] Verified `cleanMessage()` exists at `src/ipc/utils/ai_messages_utils.ts:67` - [x] Verified `CustomTagState` type in `src/components/chat/stateTypes.ts:1` - [x] `npm run fmt && npm run lint:fix && npm run ts` passes - [x] `npm test` passes (1139 tests) 🤖 Generated with [Claude Code](https://claude.com/claude-code)  --- <a href="https://app.devin.ai/review/dyad-sh/dyad/pull/3271" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open in Devin Review"> </picture> </a>  --------- Co-authored-by: Will Chen <7344640+wwwillchen@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

docs: fix inaccuracies in rule files from weekly review (#3271)
f649d236 · keppo-bot[bot] · GitHub · 7eb78f9c · f649d236 · f649d236
--- a/rules/git-workflow.md
+++ b/rules/git-workflow.md
@@ -38,6 +38,14 @@ git rev-list --left-right --count upstream/main...HEAD

 If this returns `0	0`, the branch has no commits ahead of `upstream/main`. GitHub cannot open a PR for an empty branch, so do not fabricate an empty commit just to satisfy `gh pr create`; report the branch as pushed but PR-blocked instead.

+## `gh pr create` fork-collab permission error
+
+If `gh pr create` from a fork fails with `GraphQL: Fork collab Fork collab can't be granted by someone without permission (createPullRequest)`, add `--no-maintainer-edit`. `gh` defaults to enabling maintainer edits, which requires a permission the fork account does not have for the upstream repo.
+
+```bash
+gh pr create --repo dyad-sh/dyad --head <owner>:<branch> --no-maintainer-edit --title "..." --body "..."
+```
+
 ## `gh pr create` body quoting

 When passing a PR body inline via `gh pr create --body "..."`, unescaped backticks are evaluated by `zsh` before `gh` runs. Avoid backticks in inline bodies, or use a body file / heredoc so literal code identifiers do not turn into `command not found` errors.

--- a/rules/openai-reasoning-models.md
+++ b/rules/openai-reasoning-models.md
@@ -12,4 +12,4 @@ OpenAI's Responses API requires reasoning items to always be followed by an outp
 - The stream is interrupted after reasoning but before output
 - Only reasoning was generated in a turn

-The fix in `src/ipc/utils/ai_messages_utils.ts` filters orphaned reasoning parts via `filterOrphanedReasoningParts()` before sending conversation history back to OpenAI.
+The fix in `src/ipc/utils/ai_messages_utils.ts` filters orphaned reasoning parts within `cleanMessage()` before sending conversation history back to OpenAI.