skip failing tests on windows (#2164)

 > [!NOTE] > Skips problematic Windows runs for select e2e tests to stabilize CI. > > - Switches `mcp.spec.ts`, `security_review.spec.ts`, and `supabase_migrations.spec.ts` tests to `testSkipIfWindows`, wrapping the calculator, security review (incl. edit/use knowledge), and supabase migrations (incl. native git) cases > - Cleans up imports accordingly; no application code changes > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit b3ce59d4c6da6bfbc2888636cc239ec1ed3cc6ba. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>   --- ## Summary by cubic Skip failing Windows-only e2e tests to stabilize CI; non-Windows runs are unchanged. - **Bug Fixes** - Use testSkipIfWindows for: - mcp.spec.ts: “mcp - call calculator” - security_review.spec.ts: “security review - edit and use knowledge” - supabase_migrations.spec.ts: “supabase migrations” - No test logic changes; only conditional skip on Windows. <sup>Written for commit b3ce59d4c6da6bfbc2888636cc239ec1ed3cc6ba. Summary will update on new commits.</sup>

skip failing tests on windows (#2164)
d40aa21e · Will Chen · GitHub · 6d7ed897 · d40aa21e · d40aa21e
--- a/e2e-tests/mcp.spec.ts
+++ b/e2e-tests/mcp.spec.ts
 import path from "path";
-import { test } from "./helpers/test_helper";
+import { testSkipIfWindows } from "./helpers/test_helper";
 import { expect } from "@playwright/test";

-test("mcp - call calculator", async ({ po }) => {
+testSkipIfWindows("mcp - call calculator", async ({ po }) => {
  await po.setUp();
  await po.goToSettingsTab();
  await po.page.getByRole("button", { name: "Tools (MCP)" }).click();

--- a/e2e-tests/security_review.spec.ts
+++ b/e2e-tests/security_review.spec.ts
@@ -18,23 +18,26 @@ testSkipIfWindows("security review", async ({ po }) => {
  await po.snapshotMessages();
 });

-test("security review - edit and use knowledge", async ({ po }) => {
-  await po.setUp({ autoApprove: true });
-  await po.sendPrompt("tc=1");
+testSkipIfWindows(
+  "security review - edit and use knowledge",
+  async ({ po }) => {
+    await po.setUp({ autoApprove: true });
+    await po.sendPrompt("tc=1");

-  await po.selectPreviewMode("security");
-  await po.page.getByRole("button", { name: "Edit Security Rules" }).click();
-  await po.page
-    .getByRole("textbox", { name: "# SECURITY_RULES.md\\n\\" })
-    .click();
-  await po.page
-    .getByRole("textbox", { name: "# SECURITY_RULES.md\\n\\" })
-    .fill("testing\nrules123");
-  await po.page.getByRole("button", { name: "Save" }).click();
+    await po.selectPreviewMode("security");
+    await po.page.getByRole("button", { name: "Edit Security Rules" }).click();
+    await po.page
+      .getByRole("textbox", { name: "# SECURITY_RULES.md\\n\\" })
+      .click();
+    await po.page
+      .getByRole("textbox", { name: "# SECURITY_RULES.md\\n\\" })
+      .fill("testing\nrules123");
+    await po.page.getByRole("button", { name: "Save" }).click();

-  await po.clickRunSecurityReview();
-  await po.snapshotServerDump("all-messages");
-});
+    await po.clickRunSecurityReview();
+    await po.snapshotServerDump("all-messages");
+  },
+);

 test("security review - multi-select and fix issues", async ({ po }) => {
  await po.setUp({ autoApprove: true });

--- a/e2e-tests/supabase_migrations.spec.ts
+++ b/e2e-tests/supabase_migrations.spec.ts
 import { expect } from "@playwright/test";
-import { test, testSkipIfWindows } from "./helpers/test_helper";
+import { testSkipIfWindows } from "./helpers/test_helper";
 import fs from "fs-extra";
 import path from "path";
 import { execSync } from "child_process";

-test("supabase migrations", async ({ po }) => {
+testSkipIfWindows("supabase migrations", async ({ po }) => {
  await po.setUp({ autoApprove: true });
  await po.sendPrompt("tc=add-supabase");