fix: improve terminated stream retry telemetry and bump retries to 3 (#2877)

## Summary - Include `dyadRequestId` in `terminated_stream_retry` telemetry events for better traceability - Add new `terminated_stream_retries_exhausted` telemetry event when all retries are used up (both stream_iteration and response_finalization phases) - Bump `MAX_TERMINATED_STREAM_RETRIES` from 2 to 3 ## Test plan - Existing `local_agent_handler` unit tests pass (stream retry tests verified) - Verify telemetry events include `dyadRequestId` in retry scenarios - Verify exhausted event fires when retries exceed the new limit of 3 #skip-bugbot Made with [Cursor](https://cursor.com)  --- <a href="https://app.devin.ai/review/dyad-sh/dyad/pull/2877" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a>

fix: improve terminated stream retry telemetry and bump retries to 3 (#2877)
7d4fc376 · Will Chen · GitHub · 97b705ef · 7d4fc376
--- a/src/pro/main/ipc/handlers/local_agent/local_agent_handler.ts
+++ b/src/pro/main/ipc/handlers/local_agent/local_agent_handler.ts
@@ -79,7 +79,7 @@ import { getPostCompactionMessages } from "@/ipc/handlers/compaction/compaction_
 const logger = log.scope("local_agent_handler");
 const PLANNING_QUESTIONNAIRE_TOOL_NAME = "planning_questionnaire";
-const MAX_TERMINATED_STREAM_RETRIES = 2;
+const MAX_TERMINATED_STREAM_RETRIES = 3;
 const STREAM_RETRY_BASE_DELAY_MS = 400;
 const STREAM_CONTINUE_MESSAGE =
  "[System] Your previous response stream was interrupted by a transient network error. Continue from exactly where you left off and do not repeat text that has already been sent.";
@@ -1006,6 +1006,7 @@ export async function handleLocalAgentStream(
                STREAM_RETRY_BASE_DELAY_MS * terminatedRetryCount;
              sendTelemetryEvent("local_agent:terminated_stream_retry", {
                chatId: req.chatId,
+                dyadRequestId,
                retryCount: terminatedRetryCount,
                error: String(streamError),
                phase: "stream_iteration",
@@ -1016,6 +1017,16 @@ export async function handleLocalAgentStream(
              await delay(retryDelayMs);
              continue;
            }
+            sendTelemetryEvent(
+              "local_agent:terminated_stream_retries_exhausted",
+              {
+                chatId: req.chatId,
+                dyadRequestId,
+                retryCount: terminatedRetryCount,
+                error: String(streamError),
+                phase: "stream_iteration",
+              },
+            );
            throw streamError;
          }
@@ -1044,6 +1055,7 @@ export async function handleLocalAgentStream(
                STREAM_RETRY_BASE_DELAY_MS * terminatedRetryCount;
              sendTelemetryEvent("local_agent:terminated_stream_retry", {
                chatId: req.chatId,
+                dyadRequestId,
                retryCount: terminatedRetryCount,
                error: String(err),
                phase: "response_finalization",
@@ -1054,6 +1066,18 @@ export async function handleLocalAgentStream(
              await delay(retryDelayMs);
              continue;
            }
+            if (isTerminatedStreamError(err)) {
+              sendTelemetryEvent(
+                "local_agent:terminated_stream_retries_exhausted",
+                {
+                  chatId: req.chatId,
+                  dyadRequestId,
+                  retryCount: terminatedRetryCount,
+                  error: String(err),
+                  phase: "response_finalization",
+                },
+              );
+            }
            logger.warn("Failed to retrieve stream response messages:", err);
            steps = [];
            responseMessages = [];