Enable type check tool by default (agent mode) and allow "never" for agent tool perms (#2165)

e2e-tests/snapshots/local_agent_basic.spec.ts_local-agent---dump-request-1.txt

@@ -409,6 +409,27 @@
             "$schema": "http://json-schema.org/draft-07/schema#"
           }
         }
+      },
+      {
+        "type": "function",
+        "function": {
+          "name": "run_type_checks",
+          "description": "Run TypeScript type checks on the current workspace. You can provide paths to specific files or directories, or omit the argument to get diagnostics for all files.\n\n- If a file path is provided, returns diagnostics for that file only\n- If a directory path is provided, returns diagnostics for all files within that directory\n- If no path is provided, returns diagnostics for all files in the workspace\n- This tool can return type errors that were already present before your edits, so avoid calling it with a very wide scope of files\n- NEVER call this tool on a file unless you've edited it or are about to edit it",
+          "parameters": {
+            "type": "object",
+            "properties": {
+              "paths": {
+                "type": "array",
+                "items": {
+                  "type": "string"
+                },
+                "description": "Optional. An array of paths to files or directories to read type errors for. If provided, returns diagnostics for the specified files/directories only. If not provided, returns diagnostics for all files in the workspace."
+              }
+            },
+            "additionalProperties": false,
+            "$schema": "http://json-schema.org/draft-07/schema#"
+          }
+        }
       }
     ],
     "tool_choice": "auto",

src/components/settings/AgentToolsSettings.tsx

@@ -13,7 +13,7 @@ import {
   type AgentTool,
 } from "@/hooks/useAgentTools";
 import { Loader2, ChevronRight } from "lucide-react";
-import type { AgentToolConsent } from "@/ipc/ipc_types";
+import { AgentToolConsent } from "@/lib/schemas";
 
 export function AgentToolsSettings() {
   const { tools, isLoading, setConsent } = useAgentTools();
@@ -109,7 +109,7 @@ function ToolConsentRow({
         <div className="min-w-0 flex-1">
           <div className="font-mono text-sm">{name}</div>
           <div className="text-xs text-muted-foreground truncate">
-            {description}
+            {description?.slice(0, 100)} {description?.length > 100 && "..."}
           </div>
         </div>
         <Select
@@ -122,6 +122,7 @@ function ToolConsentRow({
           <SelectContent>
             <SelectItem value="ask">Ask</SelectItem>
             <SelectItem value="always">Always allow</SelectItem>
+            <SelectItem value="never">Never allow</SelectItem>
           </SelectContent>
         </Select>
       </div>

src/hooks/useAgentTools.ts

@@ -6,7 +6,7 @@ import { useQuery, useMutation, useQueryClient } from "@tanstack/react-query";
 import { IpcClient } from "@/ipc/ipc_client";
 import type { AgentToolName } from "../pro/main/ipc/handlers/local_agent/tool_definitions";
 import type { AgentTool } from "@/ipc/ipc_types";
-import type { AgentToolConsent } from "@/ipc/ipc_types";
+import { AgentToolConsent } from "@/lib/schemas";
 
 // Re-export types for convenience
 export type { AgentToolName, AgentTool };

src/ipc/ipc_types.ts

 import { z } from "zod";
 import type { ProblemReport, Problem } from "../../shared/tsc_types";
+import { AgentToolConsent } from "@/lib/schemas";
 export type { ProblemReport, Problem };
 
 export interface AppOutput {
@@ -709,12 +710,6 @@ export interface AgentToolConsentResponseParams {
   decision: AgentToolConsentDecision;
 }
 
-// ============================================================================
-// Consent Types
-// ============================================================================
-
-export type AgentToolConsent = "ask" | "always";
-
 // ============================================================================
 // Agent Todo Types
 // ============================================================================

src/lib/schemas.ts

@@ -242,7 +242,7 @@ export const SmartContextModeSchema = z.enum([
 ]);
 export type SmartContextMode = z.infer<typeof SmartContextModeSchema>;
 
-export const AgentToolConsentSchema = z.enum(["ask", "always"]);
+export const AgentToolConsentSchema = z.enum(["ask", "always", "never"]);
 export type AgentToolConsent = z.infer<typeof AgentToolConsentSchema>;
 
 /**

src/pro/main/ipc/handlers/local_agent/tool_definitions.ts

@@ -33,7 +33,7 @@ import {
   type AgentContext,
   type ToolResult,
 } from "./tools/types";
-import type { AgentToolConsent } from "@/ipc/ipc_types";
+import { AgentToolConsent } from "@/lib/schemas";
 import { getSupabaseClientCode } from "@/supabase_admin/supabase_context";
 // Combined tool definitions array
 export const TOOL_DEFINITIONS: readonly ToolDefinition[] = [
@@ -170,6 +170,8 @@ export async function requireAgentToolConsent(
   const current = getAgentToolConsent(params.toolName);
 
   if (current === "always") return true;
+  if (current === "never")
+    throw new Error("Should not ask for consent for a tool marked as 'never'");
 
   // Ask renderer for a decision via event bridge
   const requestId = `agent:${params.toolName}:${crypto.randomUUID()}`;
@@ -258,6 +260,11 @@ export function buildAgentToolSet(ctx: AgentContext) {
   const toolSet: Record<string, any> = {};
 
   for (const tool of TOOL_DEFINITIONS) {
+    const consent = getAgentToolConsent(tool.name);
+    if (consent === "never") {
+      continue;
+    }
+
     if (tool.isEnabled && !tool.isEnabled(ctx)) {
       continue;
     }

src/pro/main/ipc/handlers/local_agent/tools/run_type_checks.ts

@@ -7,7 +7,7 @@ import {
 } from "./types";
 import { generateProblemReport } from "@/ipc/processors/tsc";
 import type { Problem } from "@/ipc/ipc_types";
-import { readSettings } from "@/main/settings";
+
 import { normalizePath } from "../../../../../../../shared/normalizePath";
 
 const runTypeChecksSchema = z.object({
@@ -76,7 +76,6 @@ export const runTypeChecksTool: ToolDefinition<
 - NEVER call this tool on a file unless you've edited it or are about to edit it`,
   inputSchema: runTypeChecksSchema,
   defaultConsent: "always",
-  isEnabled: () => !!readSettings().enableAutoFixProblems,
 
   getConsentPreview: (args) =>
     args.paths && args.paths.length > 0

src/pro/main/ipc/handlers/local_agent/tools/types.ts

@@ -5,7 +5,8 @@
 import { z } from "zod";
 import { IpcMainInvokeEvent } from "electron";
 import { jsonrepair } from "jsonrepair";
-import { AgentToolConsent, AgentTodo } from "@/ipc/ipc_types";
+import { AgentToolConsent } from "@/lib/schemas";
+import { AgentTodo } from "@/ipc/ipc_types";
 
 // ============================================================================
 // XML Escape Helpers