fix(e2e): deflake context_limit_banner, attach_image, and prompt_libr… (#2725)

e2e-tests/attach_image.spec.ts

@@ -104,6 +104,11 @@ test("attach image - chat - upload to codebase", async ({ po }) => {
 
   await po.sendPrompt("[[UPLOAD_IMAGE_TO_CODEBASE]]");
 
+  // Wait for the uploaded file card to render before snapshotting
+  await expect(
+    po.page.getByRole("button", { name: /file\.png/ }),
+  ).toBeVisible();
+
   await po.snapshotServerDump("last-message", { name: "upload-to-codebase" });
   await po.snapshotMessages({ replaceDumpPath: true });
 

e2e-tests/context_limit_banner.spec.ts

@@ -15,7 +15,7 @@ test("context limit banner shows 'running out' when near context limit", async (
   const contextLimitBanner = po.chatActions
     .getChatInputContainer()
     .getByTestId("context-limit-banner");
-  await expect(contextLimitBanner).toBeVisible({ timeout: Timeout.MEDIUM });
+  await expect(contextLimitBanner).toBeVisible({ timeout: Timeout.LONG });
 
   // Verify banner text for near-limit case
   await expect(contextLimitBanner).toContainText(
@@ -57,7 +57,7 @@ test("context limit banner shows 'costs extra' for long context", async ({
   const contextLimitBanner = po.chatActions
     .getChatInputContainer()
     .getByTestId("context-limit-banner");
-  await expect(contextLimitBanner).toBeVisible({ timeout: Timeout.MEDIUM });
+  await expect(contextLimitBanner).toBeVisible({ timeout: Timeout.LONG });
 
   // Verify banner text for long context case
   await expect(contextLimitBanner).toContainText(

e2e-tests/prompt_library.spec.ts

@@ -11,7 +11,14 @@ test("create and edit prompt", async ({ po }) => {
     content: "prompt1content",
   });
 
-  await expect(po.page.getByTestId("prompt-card")).toMatchAriaSnapshot();
+  // Wait for prompt card to be fully rendered
+  const promptCard = po.page.getByTestId("prompt-card");
+  await expect(promptCard).toBeVisible();
+  await expect(
+    promptCard.getByRole("heading", { name: "title1" }),
+  ).toBeVisible();
+  await expect(promptCard).toContainText("desc");
+  await expect(promptCard).toContainText("prompt1content");
 
   await po.page.getByTestId("edit-prompt-button").click();
   await po.page
@@ -19,7 +26,13 @@ test("create and edit prompt", async ({ po }) => {
     .fill("prompt1content-edited");
   await po.page.getByRole("button", { name: "Save" }).click();
 
-  await expect(po.page.getByTestId("prompt-card")).toMatchAriaSnapshot();
+  // Verify edited content is displayed
+  await expect(promptCard).toBeVisible();
+  await expect(
+    promptCard.getByRole("heading", { name: "title1" }),
+  ).toBeVisible();
+  await expect(promptCard).toContainText("desc");
+  await expect(promptCard).toContainText("prompt1content-edited");
 });
 
 test("delete prompt", async ({ po }) => {

e2e-tests/snapshots/prompt_library.spec.ts_create-and-edit-prompt-1.aria.yml

-- heading "title1" [level=3]
-- paragraph: desc
-- button:
-  - img
-- button:
-  - img
-- text: prompt1content
\ No newline at end of file

e2e-tests/snapshots/prompt_library.spec.ts_create-and-edit-prompt-2.aria.yml

-- heading "title1" [level=3]
-- paragraph: desc
-- button:
-  - img
-- button:
-  - img
-- text: prompt1content-edited
\ No newline at end of file