Unverified 提交 18846946 authored 作者: Will Chen's avatar Will Chen 提交者: GitHub

De-flake preview iframe error msg removal (#69)

上级 d1df8b10
...@@ -414,6 +414,9 @@ export const PreviewIframe = ({ loading }: { loading: boolean }) => { ...@@ -414,6 +414,9 @@ export const PreviewIframe = ({ loading }: { loading: boolean }) => {
</div> </div>
) : ( ) : (
<iframe <iframe
onLoad={() => {
setErrorMessage(undefined);
}}
ref={iframeRef} ref={iframeRef}
key={reloadKey} key={reloadKey}
title={`Preview for App ${selectedAppId}`} title={`Preview for App ${selectedAppId}`}
......
...@@ -82,8 +82,7 @@ export function useRunApp() { ...@@ -82,8 +82,7 @@ export function useRunApp() {
const onHotModuleReload = useCallback(() => { const onHotModuleReload = useCallback(() => {
setPreviewPanelKey((prevKey) => prevKey + 1); setPreviewPanelKey((prevKey) => prevKey + 1);
setPreviewErrorMessage(undefined); }, [setPreviewPanelKey]);
}, [setPreviewPanelKey, setPreviewErrorMessage]);
const restartApp = useCallback( const restartApp = useCallback(
async ({ async ({
...@@ -151,8 +150,7 @@ export function useRunApp() { ...@@ -151,8 +150,7 @@ export function useRunApp() {
const refreshAppIframe = useCallback(async () => { const refreshAppIframe = useCallback(async () => {
setPreviewPanelKey((prevKey) => prevKey + 1); setPreviewPanelKey((prevKey) => prevKey + 1);
setPreviewErrorMessage(undefined); }, [setPreviewPanelKey]);
}, [setPreviewPanelKey, setPreviewErrorMessage]);
return { return {
loading, loading,
......
Markdown 格式
0%
您添加了 0 到此讨论。请谨慎行事。
请先完成此评论的编辑!
注册 或者 后发表评论