Unverified 提交 0abc6dec authored 作者: Will Chen's avatar Will Chen 提交者: GitHub

ci: add reboot and verification steps to nightly runner cleanup (drive-by clean…

ci: add reboot and verification steps to nightly runner cleanup (drive-by clean up fast push) (#2708) ## Summary - Add reboot step after cleanup script to ensure fresh runner state - Add verification job that runs on all CI runners to check disk space post-reboot - Verification job runs even if cleanup fails (since reboot kills the runner mid-job) ## Test plan - Verify the workflow structure is valid by checking GitHub Actions UI - Monitor next nightly run to ensure reboot completes successfully - Confirm verification job runs and reports disk space 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- devin-review-badge-begin --> --- <a href="https://app.devin.ai/review/dyad-sh/dyad/pull/2708" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a> <!-- devin-review-badge-end -->
上级 5b2bd896
...@@ -156,17 +156,6 @@ You MUST use the TaskCreate and TaskUpdate tools to track your progress. At the ...@@ -156,17 +156,6 @@ You MUST use the TaskCreate and TaskUpdate tools to track your progress. At the
Use the commit messages and changed files to write a good title and summary. Use the commit messages and changed files to write a good title and summary.
**Add labels for non-trivial PRs:**
After creating or verifying the PR exists, assess whether the changes are non-trivial:
- Non-trivial = more than simple typo fixes, formatting, or config changes
- Non-trivial = any code logic changes, new features, bug fixes, refactoring
For non-trivial PRs, add the `cc:request` label to request code review:
```
gh pr edit --add-label "cc:request"
```
**Remove review-issue label:** **Remove review-issue label:**
After pushing, remove the `needs-human:review-issue` label if it exists (this label indicates the issue needed human review before work started, which is now complete): After pushing, remove the `needs-human:review-issue` label if it exists (this label indicates the issue needed human review before work started, which is now complete):
......
# Nightly disk cleanup for self-hosted macOS CI runners. # Nightly disk cleanup for self-hosted macOS CI runners.
# Runs at 4:00 AM PST to prevent disk exhaustion from CI workloads. # Runs at 4:00 AM PST to prevent disk exhaustion from CI workloads.
# After cleanup, reboots runners, then a verification job checks disk space.
# Safe to run manually via workflow_dispatch for testing. # Safe to run manually via workflow_dispatch for testing.
#
# NOTE: Runners must have the GitHub Actions runner service configured as a
# LaunchDaemon (or equivalent) so that it auto-starts after reboot.
# Without this, the verify job will hang waiting for a runner that never
# re-registers with GitHub Actions.
name: Nightly Runner Cleanup name: Nightly Runner Cleanup
...@@ -25,3 +31,25 @@ jobs: ...@@ -25,3 +31,25 @@ jobs:
env: env:
CI_NIGHTLY_CLEANUP: "1" CI_NIGHTLY_CLEANUP: "1"
run: bash scripts/ci-cleanup-macos.sh run: bash scripts/ci-cleanup-macos.sh
- name: Reboot runner
run: sudo reboot
verify:
needs: cleanup
# Run even if cleanup "fails" (reboot kills the runner mid-job), but still
# respect manual workflow cancellation.
if: ${{ !cancelled() }}
timeout-minutes: 15
strategy:
fail-fast: false
matrix:
runner: [ci1, ci2, ci3]
runs-on: ${{ matrix.runner }}
steps:
- name: Print available disk space
run: |
echo "=== Post-Reboot Disk Space ==="
df -h /
echo ""
echo "Available space: $(df -h / | tail -1 | awk '{print $4}')"
Markdown 格式
0%
您添加了 0 到此讨论。请谨慎行事。
请先完成此评论的编辑!
注册 或者 后发表评论