• Will Chen's avatar
    Auto-discover Windows SDK SignTool path in release workflow (#2445) · f0ae4e98
    Will Chen 提交于
    ## Summary
    - Auto-discover signtool.exe from Windows SDK instead of relying on
    `SIGNTOOL_PATH` repository variable
    - Add `/debug` flag to signtool for better diagnostics during signing
    failures
    - Remove `SIGNTOOL_PATH` env var from the electron-builder step since
    it's now set dynamically
    
    #skip-bugbot
    
    ## Test plan
    - Verify the release workflow runs successfully on Windows runners
    - Check that signtool.exe is found from the Windows SDK directory
    - Confirm signing output includes debug information
    
    🤖 Generated with [Claude Code](https://claude.com/claude-code)
    <!-- devin-review-badge-begin -->
    
    ---
    
    <a href="https://app.devin.ai/review/dyad-sh/dyad/pull/2445">
      <picture>
    <source media="(prefers-color-scheme: dark)"
    srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1">
    <img
    src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1"
    alt="Open with Devin">
      </picture>
    </a>
    <!-- devin-review-badge-end -->
    
    
    <!-- This is an auto-generated description by cubic. -->
    ---
    ## Summary by cubic
    Automatically discover the Windows SDK SignTool in the release workflow
    and set its path via GITHUB_ENV, removing the need for the SIGNTOOL_PATH
    repo variable. Adds /debug to SignTool for clearer diagnostics during
    signing.
    
    - **Refactors**
    - Auto-find x64 signtool.exe from the Windows SDK and export
    SIGNTOOL_PATH dynamically.
      - Add /debug to signWithParams for better logging.
      - Remove SIGNTOOL_PATH from the electron-builder step.
    
    <sup>Written for commit e667e794ac6b4c13bf34ab2943182fd22de26da0.
    Summary will update on new commits.</sup>
    
    <!-- End of auto-generated description by cubic. -->
    Co-authored-by: 's avatarClaude Opus 4.5 <noreply@anthropic.com>
    f0ae4e98