## Summary
- Fixed flaky SecurityReview E2E test by waiting for the "Running
Security Review..." button state to appear and disappear, rather than
just waiting for the original button to hide
- Added documentation to `rules/e2e-testing.md` with a pattern for
handling button state transitions in E2E tests

## Test plan
- Run the SecurityReview E2E test multiple times to verify it's no
longer flaky
- `npm run e2e -- e2e-tests/security-review.spec.ts --repeat-each=10`

🤖 Generated with [Claude Code](https://claude.com/claude-code)
<!-- devin-review-badge-begin -->

---

<a href="https://app.devin.ai/review/dyad-sh/dyad/pull/2696"
target="_blank">
  <picture>
<source media="(prefers-color-scheme: dark)"
srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1">
<img
src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1"
alt="Open with Devin">
  </picture>
</a>
<!-- devin-review-badge-end -->

---------
Co-authored-by: Will Chen <willchen90@gmail.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>