• wwwillchen-bot's avatar
    Fix flaky e2e tests with better selectors and waits (#2498) · 90f5ca33
    wwwillchen-bot 提交于
    ## Summary
    - Fix flaky e2e tests across 6 test files by adding proper awaits,
    better CSS class matching, accordion state checks, and explicit waits
    for UI elements
    - Key fixes: missing `await` on expect in delete_app, regex anchoring
    for favorite_app class matching, accordion expansion guards in
    git_collaboration, `pressSequentially` for mention trigger detection,
    and visibility waits in supabase_migrations
    
    ## Test plan
    - Run the full e2e test suite to verify the fixed tests pass reliably
    - Specifically verify: `delete_app`, `favorite_app`, `file_tree_search`,
    `git_collaboration`, `mention_files`, and `supabase_migrations` tests
    
    🤖 Generated with [Claude Code](https://claude.com/claude-code)
    <!-- devin-review-badge-begin -->
    
    ---
    
    <a href="https://app.devin.ai/review/dyad-sh/dyad/pull/2498">
      <picture>
    <source media="(prefers-color-scheme: dark)"
    srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1">
    <img
    src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1"
    alt="Open with Devin">
      </picture>
    </a>
    <!-- devin-review-badge-end -->
    
    <!-- This is an auto-generated description by cubic. -->
    ---
    ## Summary by cubic
    Stabilized flaky e2e tests by improving selectors and adding explicit
    waits. Reliability is improved across delete_app, favorite_app,
    file_tree_search, git_collaboration, mention_files, and
    supabase_migrations.
    
    - **Bug Fixes**
      - Added missing await for visibility assertion in delete_app.
      - Anchored favorite star class regex to avoid matching hover:fill.
      - Updated file_tree_search to expect main.tsx.
    - Guarded Git Collaboration flows by checking accordion expansion and
    element visibility; standardized on Timeout.MEDIUM.
    - Used pressSequentially and waits for @ mention menu; verified Supabase
    migrations switch with toBeChecked() after visibility.
    
    <sup>Written for commit a28a3d981e049c023f3a5343ae57b813961a6680.
    Summary will update on new commits.</sup>
    
    <!-- End of auto-generated description by cubic. -->
    
    ---------
    Co-authored-by: 's avatarWill Chen <willchen90@gmail.com>
    Co-authored-by: 's avatarClaude Opus 4.5 <noreply@anthropic.com>
    90f5ca33
supabase_migrations.spec.ts 4.6 KB