• wwwillchen-bot's avatar
    Improve E2E test stability for Capacitor and Next.js component selection (#2646) · 4936b851
    wwwillchen-bot 提交于
    ## Summary
    - Add error dialog handling in capacitor.spec.ts to gracefully dismiss
    sync errors that may occur in E2E environment due to missing
    CocoaPods/Xcode
    - Improve timing and wait logic in select_component.spec.ts for Next.js
    apps which take longer to compile and start the dev server
    - Update snapshot to use placeholder for system message instead of
    hardcoded content
    
    ## Test plan
    - Run `npm run test:e2e -- --grep "capacitor"` to verify the Capacitor
    test improvements
    - Run `npm run test:e2e -- --grep "select component next.js"` to verify
    the Next.js component selection test improvements
    - Verify that tests pass consistently without flakiness
    
    🤖 Generated with [Claude Code](https://claude.com/claude-code)
    <!-- devin-review-badge-begin -->
    
    ---
    
    <a href="https://app.devin.ai/review/dyad-sh/dyad/pull/2646"
    target="_blank">
      <picture>
    <source media="(prefers-color-scheme: dark)"
    srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1">
    <img
    src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1"
    alt="Open with Devin">
      </picture>
    </a>
    <!-- devin-review-badge-end -->
    
    
    <!-- This is an auto-generated description by cubic. -->
    ---
    ## Summary by cubic
    Stabilizes E2E tests by handling Capacitor sync errors and improving
    Next.js component selection timing to reduce flakiness. Also updates the
    snapshot to use a system message placeholder.
    
    - **Bug Fixes**
    - Capacitor: wait for sync completion and dismiss error dialog when
    CocoaPods/Xcode are missing.
    - Next.js: wait for preview iframe and heading visibility; add retry
    with toPass() for component selection.
    - Snapshot: replace hardcoded system message with [[SYSTEM_MESSAGE]]
    placeholder.
    
    <sup>Written for commit 0e33279d8d18c124ca11e95818ce76b8d9b7b4de.
    Summary will update on new commits.</sup>
    
    <!-- End of auto-generated description by cubic. -->
    Co-authored-by: 's avatarWill Chen <willchen90@gmail.com>
    Co-authored-by: 's avatarClaude Opus 4.5 <noreply@anthropic.com>
    4936b851
select_component.spec.ts 6.0 KB