• Will Chen's avatar
    Improve swarm PR review to detect dead infrastructure (#2529) · 7a173b21
    Will Chen 提交于
    ## Summary
    - Updated the code health reviewer role to explicitly check for **dead
    infrastructure**: DB migrations creating unused tables, API endpoints
    with no callers, config entries nothing references
    - Added cross-referencing guidance to the teammate prompt template so
    all reviewers verify schema/infra changes against actual code usage
    
    ## Context
    During review of PR #2370, the swarm review missed that a `plans` DB
    table migration was created but the implementation used file-based
    storage instead. This update ensures future reviews catch such
    mismatches.
    
    ## Test plan
    - [x] No code changes, only `.claude/skills/` markdown files updated
    - [x] Lint, type checks, and all 784 tests pass
    
    #skip-bugbot
    
    🤖 Generated with [Claude Code](https://claude.com/claude-code)
    <!-- devin-review-badge-begin -->
    
    ---
    
    <a href="https://app.devin.ai/review/dyad-sh/dyad/pull/2529"
    target="_blank">
      <picture>
    <source media="(prefers-color-scheme: dark)"
    srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1">
    <img
    src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1"
    alt="Open with Devin">
      </picture>
    </a>
    <!-- devin-review-badge-end -->
    
    <!-- This is an auto-generated description by cubic. -->
    ---
    ## Summary by cubic
    Improves the swarm PR review to catch dead infrastructure by adding
    explicit checks and cross-referencing of schema/API/config changes
    against actual usage. Prevents misses like unused DB tables by updating
    reviewer roles, prompts, and enabling agent teams.
    
    - **New Features**
    - Added dead infrastructure checks to the code health reviewer (DB
    migrations, endpoints, configs) with severity guidance.
    - Added a standardized swarm review skill (SKILL.md + role refs) and
    updated prompts to enforce cross-referencing against code usage.
    - Enabled agent teams via settings
    (CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS=1); no runtime code changes.
    
    <sup>Written for commit 78e829037cc0bc66382502b25092184f5d8f05ae.
    Summary will update on new commits.</sup>
    
    <!-- End of auto-generated description by cubic. -->
    
    ---------
    Co-authored-by: 's avatarClaude Opus 4.6 <noreply@anthropic.com>
    7a173b21
code-health-reviewer.md 2.9 KB