Remove unnecessary implicit COp.python_constant_folding function

aesara/gpuarray/elemwise.py

@@ -414,9 +414,11 @@ class GpuElemwise(_NoPythonOp, HideC, Elemwise):
 
         return str(code)
 
-    # Since we don't have a perform ...
-    def python_constant_folding(self, node):
-        return False
+    def prepare_node(self, node, storage_map, compute_map, no_recycling, impl=None):
+        # Since we don't have a Python implementation, ignore `impl` and use C.
+        return super().prepare_node(
+            node, storage_map, compute_map, no_recycling, impl="c"
+        )
 
     def c_code_cache_version(self):
         ver = self.scalar_op.c_code_cache_version()

aesara/tensor/basic_opt.py

@@ -4347,18 +4347,12 @@ def constant_folding(fgraph, node):
     for o in node.outputs:
         storage_map[o] = [None]
         compute_map[o] = [False]
-    impl = None
-    if hasattr(node.op, "python_constant_folding") and node.op.python_constant_folding(
-        node
-    ):
-        impl = "py"
-    thunk = node.op.make_thunk(
-        node, storage_map, compute_map, no_recycling=[], impl=impl
-    )
 
+    thunk = node.op.make_thunk(node, storage_map, compute_map, no_recycling=[])
     required = thunk()
-    assert not required  # a node whose inputs are all provided should always
-    # return successfully
+    # A node whose inputs are all provided should always return successfully
+    assert not required
+
     rval = []
     for output in node.outputs:
         assert compute_map[output][0], (output, storage_map[output][0])

aesara/tensor/elemwise.py

@@ -665,6 +665,9 @@ second dimension
         # - NumPy ufunc support only up to 31 inputs.
         #   But our c code support more.
         # - nfunc is reused for scipy and scipy is optional
+        if len(node.inputs) > 32 and self.ufunc and impl == "py":
+            impl = "c"
+
         if getattr(self, "nfunc_spec", None) and impl != "c":
             self.nfunc = getattr(np, self.nfunc_spec[0], None)
             if self.nfunc is None:
@@ -1255,14 +1258,6 @@ second dimension
         else:
             return ()
 
-    def python_constant_folding(self, node):
-        """
-        Return True if we do not want to compile c code
-        when doing constant folding of this node.
-        """
-        # The python code don't support 32 inputs or more.
-        return node.outputs[0].ndim == 0 and len(node.inputs) < 32
-
 
 class CAReduce(COp):
     """

doc/extending/cop.txt

@@ -209,20 +209,6 @@ There are less methods to define for a `COp` than for a `Type`:
        Overrides :meth:`c_code_cache_version` if defined, but
        otherwise has the same contract.
 
-    .. method:: python_constant_folding(node)
-
-       Optional. If present this method will be called before doing
-       constant folding of a node, with that node as a parameter. If
-       it return True, we will not generate C code when doing constant
-       folding of this node.  This is useful when the compilation of
-       the C code will be longer then the computation in python
-       (e.g. Elemwise of scalars).
-
-       In addition, this allow to lower the number of compiled module
-       and disk access. Particularly useful when the file system load
-       is high or when aesara compilation directory is shared by many
-       process (like on a network file server on a cluster).
-
     .. method:: get_params(node)
 
        (optional) If defined, should return the runtime params the op