Raise TypeError instead of ValueError

theano/tensor/basic.py

@@ -4732,14 +4732,14 @@ def inc_subtensor(x, y, inplace=False, set_instead_of_inc=False,
     x = as_tensor_variable(x)
     y = as_tensor_variable(y)
     if y.ndim > x.ndim:
-        raise ValueError(("Trying to increment a %d-dimensional "
+        raise TypeError(("Trying to increment a %d-dimensional "
             "subtensor with a %d-dimensional value.") % (x.ndim, y.ndim))
 
     for dim in range(y.ndim):
         dim_offset = x.ndim - y.ndim
         if (x.broadcastable[dim + dim_offset]
                 and not y.broadcastable[dim]):
-            raise ValueError(("Trying to increment a subtensor with "
+            raise TypeError(("Trying to increment a subtensor with "
                 "broadcastable dimension %d, with a tensor not broadcastable "
                 "on corresponding dimension %d.") % (dim + dim_offset, dim),
                 x.broadcastable, y.broadcastable)

theano/tensor/tests/test_inc_subtensor.py

@@ -61,17 +61,17 @@ class Test_inc_subtensor(unittest.TestCase):
         increment = tt.matrix()
         index = 0
 
-        self.assertRaises(ValueError, tt.set_subtensor, a[index], increment)
-        self.assertRaises(ValueError, tt.inc_subtensor, a[index], increment)
+        self.assertRaises(TypeError, tt.set_subtensor, a[index], increment)
+        self.assertRaises(TypeError, tt.inc_subtensor, a[index], increment)
 
     def test_wrong_broadcast(self):
         a = tt.col()
         increment = tt.vector()
 
-        self.assertRaises(ValueError, tt.set_subtensor, a[:], increment)
-        self.assertRaises(ValueError, tt.set_subtensor, a[0], increment)
-        self.assertRaises(ValueError, tt.inc_subtensor, a[:], increment)
-        self.assertRaises(ValueError, tt.inc_subtensor, a[0], increment)
+        self.assertRaises(TypeError, tt.set_subtensor, a[:], increment)
+        self.assertRaises(TypeError, tt.set_subtensor, a[0], increment)
+        self.assertRaises(TypeError, tt.inc_subtensor, a[:], increment)
+        self.assertRaises(TypeError, tt.inc_subtensor, a[0], increment)
 
     def test_simple_3d(self):
         """Increments or sets part of a tensor by a scalar using full slice and