Cleaner inheritance for GpuAlloc.make_node()

theano/sandbox/cuda/basic_ops.py

@@ -3261,9 +3261,9 @@ class GpuAllocEmpty(GpuOp):
     """Implement Alloc on the gpu, but without initializing memory."""
     __props__ = ()
 
-    def make_node(self, *shape):
+    @staticmethod
+    def validate_shape(shape):
         sh = [tensor.as_tensor_variable(s) for s in shape]
-
         bcast = []
         for s in sh:
             if s.type.dtype[:3] not in ('int', 'uin'):
@@ -3276,8 +3276,12 @@ class GpuAllocEmpty(GpuOp):
             bcast.append(numpy.all(1 == const_shp))
         otype = CudaNdarrayType(dtype='float32', broadcastable=bcast)
         output = otype()
+        return sh, output
+
+    def make_node(self, *shape):
+        shape, output = self.validate_shape(shape)
         output.values_eq_approx = tensor.type.values_eq_approx_always_true
-        return Apply(self, sh, [output])
+        return Apply(self, shape, [output])
 
     def perform(self, node, inputs, out_):
         out, = out_
@@ -3324,7 +3328,6 @@ class GpuAllocEmpty(GpuOp):
         return (1,)
 
     def do_constant_folding(self, node):
-        # XXX: anything needed here?
         return False
 
 gpu_alloc_empty = GpuAllocEmpty()
@@ -3351,14 +3354,13 @@ class GpuAlloc(GpuAllocEmpty):
         return s
 
     def make_node(self, value, *shape):
-        node = super(GpuAlloc, self).make_node(*shape)
-        node.outputs[0].owner = None
-        #if their is unneeded transfert generated by the next line
+        #if there is unneeded transfert generated by the next line
         #the optimizer will remove them.
         v = as_cuda_ndarray_variable(value)
         if v.ndim != len(shape):
             value = tensor.shape_padleft(value, len(shape) - v.ndim)
-        return Apply(self, [v] + node.inputs, node.outputs)
+        shape, output = self.validate_shape(shape)
+        return Apply(self, [v] + shape, [output])
 
     def perform(self, node, inputs, out_):
         # the super class (GpuAllocEmpty) allocates memory, we fill it