test csc for vector add and correct optimization

theano/sparse/sandbox/sp2.py

@@ -623,7 +623,7 @@ def local_structured_add_s_v(node):
             CSx = CSR
             structured_add_s_v_csx = structured_add_s_v_csr
         else:
-            raise NotImplemented()
+            return False
 
         s_val, s_ind, s_ptr, s_shape = csm_properties(svar)
 

theano/sparse/tests/test_sp2.py

@@ -57,7 +57,7 @@ class test_structured_add_s_v(unittest.TestCase):
         sp_types = {'csc': sp.csc_matrix,
             'csr': sp.csr_matrix}
         
-        for format in ['csr']:
+        for format in ['csr', 'csc']:
             for dtype in ['float32', 'float64']:
                 spmat = sp_types[format](random_lil((4, 3), dtype, 3))
                 mat = numpy.ones(3, dtype=dtype)
@@ -69,7 +69,7 @@ class test_structured_add_s_v(unittest.TestCase):
         sp_types = {'csc': sp.csc_matrix,
             'csr': sp.csr_matrix}
         
-        for format in ['csr']:
+        for format in ['csr', 'csc']:
             for dtype in ['float32', 'float64']:
                 x = S.SparseType(format, dtype=dtype)()
                 y = T.vector(dtype=dtype)