flake8 of theano/gof/fg.py

theano/gof/fg.py

@@ -13,7 +13,6 @@ from theano.gof import graph
 from theano.gof import utils
 from theano.gof import toolbox
 from theano import config
-import warnings
 
 from theano.compat import OrderedDict
 from six import iteritems, itervalues
@@ -22,6 +21,7 @@ from theano.misc.ordered_set import OrderedSet
 
 NullType = None
 
+
 class CachedConstantError(Exception):
     """An exception thrown when we put in a FunctionGraph a Constant
     that is cached.  This should not happen as the user can reuse this
@@ -143,7 +143,7 @@ class FunctionGraph(utils.object2):
         self.variable_locks = {}
         self.profile = None
 
-    ### Setup a Variable ###
+    # Setup a Variable #
     def __setup_r__(self, r):
         # sets up r so it belongs to this fgraph
         if getattr(r, 'cached', False):
@@ -152,12 +152,12 @@ class FunctionGraph(utils.object2):
                 " graph that has a cached constant. This should not happen."
                 " Clone the graph before building the FunctionGraph.")
         if (hasattr(r, 'fgraph') and
-            r.fgraph is not None and
-            r.fgraph is not self):
+                r.fgraph is not None and
+                r.fgraph is not self):
             raise Exception("%s is already owned by another fgraph" % r)
         r.fgraph = self
         r.clients = []
-        #self.execute_callbacks('on_setup_variable', r)
+        # self.execute_callbacks('on_setup_variable', r)
 
     def __setup_node__(self, node):
         # sets up node so it belongs to this fgraph
@@ -177,7 +177,7 @@ class FunctionGraph(utils.object2):
                                 str(node.op), str(node.op.destroy_map)))
         node.fgraph = self
         node.deps = {}
-        #self.execute_callbacks('on_setup_node', node)
+        # self.execute_callbacks('on_setup_node', node)
 
     def disown(self):
         """ WRITEME
@@ -201,7 +201,7 @@ class FunctionGraph(utils.object2):
         self.inputs = None
         self.outputs = None
 
-    ### clients ###
+    # clients #
     def clients(self, r):
         """
         Set of all the (node, i) pairs such that node.inputs[i] is r.
@@ -221,9 +221,9 @@ class FunctionGraph(utils.object2):
         if set(r.clients).intersection(set(new_clients)):
             print('ERROR: clients intersect!', file=sys.stderr)
             print('  RCLIENTS of', r, [(n, i, type(n), id(n))
-                                                      for n, i in r.clients], file=sys.stderr)
+                                       for n, i in r.clients], file=sys.stderr)
             print('  NCLIENTS of', r, [(n, i, type(n), id(n))
-                                                      for n, i in new_clients], file=sys.stderr)
+                                       for n, i in new_clients], file=sys.stderr)
         assert not set(r.clients).intersection(set(new_clients))
         r.clients += new_clients
 
@@ -245,7 +245,7 @@ class FunctionGraph(utils.object2):
             return True
         return False
 
-    ### import ###
+    # import #
     def __import_r__(self, variable, reason):
         global NullType
         if NullType is None:
@@ -279,9 +279,8 @@ class FunctionGraph(utils.object2):
                     if hasattr(r, 'fgraph') and r.fgraph is not self:
                         raise Exception("%s is already owned by another fgraph" % r)
                     if (r.owner is None and
-                        not isinstance(r, graph.Constant) and
-                        r not in self.inputs):
-
+                            not isinstance(r, graph.Constant) and
+                            r not in self.inputs):
                         # Verbose error message
                         # Show a complete chain of variables from the missing input to an output
                         if config.exception_verbosity == 'high':
@@ -373,7 +372,7 @@ class FunctionGraph(utils.object2):
             assert node.fgraph is self
             self.execute_callbacks('on_import', node, reason)
 
-    ### prune ###
+    # prune #
     def __prune_r__(self, variable, reason=None):
         """Should be called for variable that aren't used anymore:
         len(var.clients) == 0
@@ -430,7 +429,7 @@ class FunctionGraph(utils.object2):
             self.__remove_clients__(input, [(apply_node, i)], reason=reason)
         # self.__prune_r__(apply_node.inputs)
 
-    ### change input ###
+    # change input #
     def change_input(self, node, i, new_r, reason=None):
         """WRITEME
         Changes node.inputs[i] to new_r.
@@ -475,7 +474,7 @@ class FunctionGraph(utils.object2):
         if prune:
             self.__prune_r__(r, reason=reason)
 
-    ### replace ###
+    # replace #
     def replace(self, r, new_r, reason=None, verbose=None):
         """ WRITEME
         This is the main interface to manipulate the subgraph in FunctionGraph.
@@ -582,7 +581,7 @@ class FunctionGraph(utils.object2):
         if detach is not None:
             detach(self)
 
-    ### callback utils ###
+    # callback utils #
     def execute_callbacks(self, name, *args, **kwargs):
         """WRITEME
         Calls
@@ -618,7 +617,7 @@ class FunctionGraph(utils.object2):
             d[feature] = fn(*args)
         return d
 
-    ### misc ###
+    # misc #
     def toposort(self):
         """WRITEME
         Returns an ordering of the graph's Apply nodes such that:
@@ -712,8 +711,8 @@ class FunctionGraph(utils.object2):
                 missing, excess)
         for variable in variables:
             if (variable.owner is None and
-                variable not in self.inputs and
-                not isinstance(variable, graph.Constant)):
+                    variable not in self.inputs and
+                    not isinstance(variable, graph.Constant)):
                 raise Exception("Undeclared input.", variable)
             if variable.fgraph is not self:
                 raise Exception("Variable should belong to the FunctionGraph.",
@@ -737,7 +736,7 @@ class FunctionGraph(utils.object2):
     def __repr__(self):
         return self.__str__()
 
-    ### clone ###
+    # clone #
     def clone(self, check_integrity=True):
         """WRITEME"""
         return self.clone_get_equiv(check_integrity)[0]

theano/tests/test_flake8.py

@@ -243,7 +243,6 @@ whitelist_flake8 = [
     "gof/unify.py",
     "gof/graph.py",
     "gof/__init__.py",
-    "gof/fg.py",
     "gof/op.py",
     "gof/cmodule.py",
     "gof/tests/test_cmodule.py",