提交 866818d2 authored 作者: Frederic Bastien's avatar Frederic Bastien

Changed again the exception catched by TensorVariable.__add__ and like.

This allow TensorVariable + SparseVariable to work correctly by calling after that __radd__ of the SparseVariable.
上级 aac9d6b5
...@@ -1132,11 +1132,13 @@ class _tensor_py_operators: ...@@ -1132,11 +1132,13 @@ class _tensor_py_operators:
def __add__(self,other): def __add__(self,other):
try: try:
return add(self,other) return add(self,other)
# We should catch only NotImplementedError. # We should catch the minimum number of exception here.
# As otherwise this will transfer error to the wrong error # Otherwise this will convert error when Theano flags
# Theano flags compute_test_value need to be able to raise # compute_test_value is used
# other type of error. # Evidently, we need to catch NotImplementedError
except NotImplementedError, e: # But we also need to catch TypeError
# Oterwise TensorVariable * SparseVariable won't work!
except (NotImplementedError, TypeError), e:
# We must return NotImplemented and not an # We must return NotImplemented and not an
# NotImplementedError or raise an NotImplementedError. # NotImplementedError or raise an NotImplementedError.
# That way python will give a good error message like this # That way python will give a good error message like this
...@@ -1148,14 +1150,14 @@ class _tensor_py_operators: ...@@ -1148,14 +1150,14 @@ class _tensor_py_operators:
# adn the return value in that case # adn the return value in that case
try: try:
return sub(self,other) return sub(self,other)
except NotImplementedError, e: except (NotImplementedError, TypeError), e:
return NotImplemented return NotImplemented
def __mul__(self,other): def __mul__(self,other):
# See explanation in __add__ for the error catched # See explanation in __add__ for the error catched
# adn the return value in that case # adn the return value in that case
try: try:
return mul(self,other) return mul(self,other)
except NotImplementedError, e: except (NotImplementedError, TypeError), e:
return NotImplemented return NotImplemented
def __div__(self,other): def __div__(self,other):
# See explanation in __add__ for the error catched # See explanation in __add__ for the error catched
...@@ -1166,14 +1168,14 @@ class _tensor_py_operators: ...@@ -1166,14 +1168,14 @@ class _tensor_py_operators:
# This is to raise the exception that occurs when trying to divide # This is to raise the exception that occurs when trying to divide
# two integer arrays (currently forbidden). # two integer arrays (currently forbidden).
raise raise
except NotImplementedError, e: except (NotImplementedError, TypeError), e:
return NotImplemented return NotImplemented
def __pow__(self,other): def __pow__(self,other):
# See explanation in __add__ for the error catched # See explanation in __add__ for the error catched
# adn the return value in that case # adn the return value in that case
try: try:
return pow(self,other) return pow(self,other)
except NotImplementedError, e: except (NotImplementedError, TypeError), e:
return NotImplemented return NotImplemented
def __mod__(self,other): def __mod__(self,other):
# See explanation in __add__ for the error catched # See explanation in __add__ for the error catched
...@@ -1184,7 +1186,7 @@ class _tensor_py_operators: ...@@ -1184,7 +1186,7 @@ class _tensor_py_operators:
# This is to raise the exception that occurs when trying to compute # This is to raise the exception that occurs when trying to compute
# x % y with either x or y a complex number. # x % y with either x or y a complex number.
raise raise
except NotImplementedError, e: except (NotImplementedError, TypeError), e:
return NotImplemented return NotImplemented
def __truediv__(self,other): return true_div(self, other) def __truediv__(self,other): return true_div(self, other)
......
Markdown 格式
0%
您添加了 0 到此讨论。请谨慎行事。
请先完成此评论的编辑!
注册 或者 后发表评论