Flake8 and inplace removed from sparse_block_dot.

theano/sandbox/blocksparse.py

@@ -229,7 +229,7 @@ cpu_sparse_block_outer = CpuSparseBlockOuter(False)
 cpu_sparse_block_outer_inplace = CpuSparseBlockOuter(True)
 
 
-def sparse_block_dot(W, h, inputIdx, b, outputIdx, inplace=False):
+def sparse_block_dot(W, h, inputIdx, b, outputIdx):
     """
     Compute the dot product (plus bias) of the specified pieces of vectors
     and matrices. See SparseBlockGemv to get more information.
@@ -263,5 +263,5 @@ def sparse_block_dot(W, h, inputIdx, b, outputIdx, inplace=False):
         h = h.dimshuffle('x', 0, 1)
         inputIdx = inputIdx.dimshuffle('x', 0)
         outputIdx = outputIdx.dimshuffle('x', 0)
-    return SparseBlockGemv(inplace)(b.take(outputIdx, axis=0), W, h,
-                                    inputIdx, outputIdx)
+    return SparseBlockGemv()(b.take(outputIdx, axis=0), W, h,
+                             inputIdx, outputIdx)

theano/sandbox/tests/test_blocksparse.py

@@ -147,7 +147,7 @@ class BlockSparse_Gemv_and_Outer(unittest.TestCase):
         for b in range(x.shape[0]):
             for i in range(xIdx.shape[1]):
                 for j in range(yIdx.shape[1]):
-                    o[xIdx[b, i], yIdx[b, j]] += numpy.outer(x[b,  i, :],
+                    o[xIdx[b, i], yIdx[b, j]] += numpy.outer(x[b, i, :],
                                                              y[b, j, :])
         return o
 

theano/tests/test_flake8.py

@@ -98,18 +98,19 @@ whitelist_flake8 = [
     "tensor/nnet/tests/test_sigm.py",
     "scalar/__init__.py",
     "scalar/tests/test_basic.py",
-    "sandbox/tests/test_theano_object.py",
-    "sandbox/tests/test_scan.py",
-    "sandbox/tests/test_rng_mrg.py",
-    "sandbox/tests/test_neighbourhoods.py",
-    "sandbox/tests/test_multinomial.py",
-    "sandbox/tests/__init__.py"
+    "sandbox/__init__.py",
     "sandbox/rng_mrg.py",
     "sandbox/theano_object.py",
     "sandbox/scan.py",
     "sandbox/symbolic_module.py",
     "sandbox/conv.py",
     "sandbox/debug.py",
+    "sandbox/tests/test_theano_object.py",
+    "sandbox/tests/test_scan.py",
+    "sandbox/tests/test_rng_mrg.py",
+    "sandbox/tests/test_neighbourhoods.py",
+    "sandbox/tests/test_multinomial.py",
+    "sandbox/tests/__init__.py",
     "sandbox/cuda/dnn.py",
     "sandbox/cuda/var.py",
     "sandbox/cuda/GpuConvGrad3D.py",