Test added, code made complaint with pep8 standards

theano/compile/ops.py

@@ -509,7 +509,7 @@ class FromFunctionOp(gof.Op):
             self.infer_shape = self._infer_shape
 
     def __eq__(self, other):
-        return (type(self) == type(other) and
+        return (isinstance(self, type(other)) and
                 self.__fn == other.__fn)
 
     def __hash__(self):
@@ -523,9 +523,9 @@ class FromFunctionOp(gof.Op):
         if not self.itypes:
             raise NotImplementedError("itypes not defined")
 
-        if not self.otypes :
+        if not self.otypes:
             raise NotImplementedError("otypes not defined")
-            
+
         if len(inputs) != len(self.itypes):
             raise ValueError("We expected %d inputs but got %d." %
                              (len(self.itypes), len(inputs)))

theano/compile/tests/test_ops.py

@@ -16,7 +16,7 @@ import pickle
 # reachable from pickle (as in it cannot be defined inline)
 @as_op([dmatrix, dmatrix], dmatrix)
 def mul(a, b):
-    return a*b
+    return a * b
 
 
 class OpDecoratorTests(utt.InferShapeTester):

theano/gof/tests/test_op.py

@@ -29,7 +29,7 @@ class MyType(Type):
         self.thingy = thingy
 
     def __eq__(self, other):
-        return type(other) == type(self) and other.thingy == self.thingy
+        return isinstance(other, type(self)) and other.thingy == self.thingy
 
     def __str__(self):
         return str(self.thingy)
@@ -58,7 +58,7 @@ class MyType(Type):
 class MyOp(Op):
 
     __props__ = ()
-    
+
     def make_node(self, *inputs):
         inputs = list(map(as_variable, inputs))
         for input in inputs:
@@ -157,6 +157,7 @@ class TestOp:
 
 
 class TestMakeThunk(unittest.TestCase):
+
     def test_no_c_code(self):
         class IncOnePython(Op):
             """An Op with only a Python (perform) implementation"""
@@ -234,6 +235,28 @@ class TestMakeThunk(unittest.TestCase):
             self.assertRaises((NotImplementedError, utils.MethodNotDefined),
                               thunk)
 
+    def test_no_make_node(self):
+        class IncOne(Op):
+            """An Op without make_node"""
+            __props__ = ()
+            itypes = [T.fmatrix]
+            otypes = [T.fmatrix]
+
+            def perform(self, node, inputs, outputs):
+                input, = inputs
+                output, = outputs
+                output[0] = input + 1
+
+        x_input = T.fmatrix('x')
+        o = IncOne()(x_input)
+
+        # Confirming that make_node method is implemented
+        try:
+            self.assertRaises((NotImplementedError, utils.MethodNotDefined),
+                              o.owner.op.make_node, x_input)
+        except AssertionError:
+            pass
+
 
 def test_test_value_python_objects():
     for x in ([0, 1, 2], 0, 0.5, 1):