Unverified 提交 822a998f authored 作者: Will Chen's avatar Will Chen 提交者: GitHub

feat: add cc:request label step to pr-push skill (#2773)

## Summary - Add step 8 to the `pr-push` skill that automatically adds the `cc:request` label for non-trivial PRs to trigger code review - This prevents issues like lint failures from slipping through when the agent doesn't fully execute lint checks (e.g., due to token limits in long CI runs) - Renumbered subsequent steps (9-11) accordingly ## Test plan - [ ] Verify the `pr-push` skill SKILL.md has the new step 8 with clear trivial/non-trivial criteria - [ ] Verify step numbering is correct (1-11) - [ ] Run `pr-push` on a non-trivial PR and confirm `cc:request` label is added 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- devin-review-badge-begin --> --- <a href="https://app.devin.ai/review/dyad-sh/dyad/pull/2773" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a> <!-- devin-review-badge-end --> Co-authored-by: 's avatarClaude Opus 4.6 <noreply@anthropic.com>
上级 b48edb0a
...@@ -160,7 +160,28 @@ Commit any uncommitted changes, run lint checks, fix any issues, and push the cu ...@@ -160,7 +160,28 @@ Commit any uncommitted changes, run lint checks, fix any issues, and push the cu
Use the commit messages and changed files to write a good title and summary. Use the commit messages and changed files to write a good title and summary.
8. **Remove review-issue label:** 8. **Add `cc:request` label for non-trivial PRs:**
After creating or updating the PR, determine if the PR is non-trivial and add the `cc:request` label to trigger a code review.
A PR is **trivial** (skip the label) if it ONLY contains:
- Documentation-only changes (`.md` files, comments)
- Snapshot/baseline updates with no test logic changes
- Single-line typo or formatting fixes
All other PRs are **non-trivial** (add the label), including:
- Any changes to source code (`.ts`, `.tsx`, `.js`, etc.)
- Changes to test logic (not just snapshot baselines)
- Configuration changes (`.yml`, `.json`, etc.)
- Any PR touching 3+ files
If the PR is non-trivial:
```
gh pr edit --add-label "cc:request"
```
9. **Remove review-issue label:**
After pushing, remove the `needs-human:review-issue` label if it exists (this label indicates the issue needed human review before work started, which is now complete): After pushing, remove the `needs-human:review-issue` label if it exists (this label indicates the issue needed human review before work started, which is now complete):
...@@ -168,24 +189,25 @@ Commit any uncommitted changes, run lint checks, fix any issues, and push the cu ...@@ -168,24 +189,25 @@ Commit any uncommitted changes, run lint checks, fix any issues, and push the cu
gh pr edit --remove-label "needs-human:review-issue" 2>/dev/null || true gh pr edit --remove-label "needs-human:review-issue" 2>/dev/null || true
``` ```
9. **Remember learnings (after initial push):** 10. **Remember learnings (after initial push):**
Run the `/remember-learnings` skill to capture any errors, snags, or insights from this session into `AGENTS.md` or `rules/` files.
Run the `/remember-learnings` skill to capture any errors, snags, or insights from this session into `AGENTS.md` or `rules/` files. If any files were modified by the skill (check with `git status`):
If any files were modified by the skill (check with `git status`): - Stage the modified files: `git add AGENTS.md rules/`
- Stage the modified files: `git add AGENTS.md rules/` - Create a new commit for the learnings:
- Create a new commit for the learnings:
``` ```
git commit -m "docs: record session learnings" git commit -m "docs: record session learnings"
``` ```
- Push the learnings commit: - Push the learnings commit:
``` ```
git push git push
``` ```
**IMPORTANT:** Do NOT amend the previous commit. Create a separate commit for learnings so the main work is already pushed before this step. **IMPORTANT:** Do NOT amend the previous commit. Create a separate commit for learnings so the main work is already pushed before this step.
10. **Summarize the results:** 11. **Summarize the results:**
- Report if a new feature branch was created (and its name) - Report if a new feature branch was created (and its name)
- Report any uncommitted changes that were committed in step 2 - Report any uncommitted changes that were committed in step 2
......
Markdown 格式
0%
您添加了 0 到此讨论。请谨慎行事。
请先完成此评论的编辑!
注册 或者 后发表评论