Skip to content

B
bit-pm
Unverified 提交 7730b51e authored 作者: Will Chen's avatar Will Chen 提交者： GitHub
浏览文件
操作

Add PLAYWRIGHT_HTML_OPEN=never to e2e test commands (#2324)

## Summary - Add `PLAYWRIGHT_HTML_OPEN=never` environment variable to all e2e test commands in AGENTS.md and Claude command files - Prevents the Playwright HTML reporter from opening a browser and blocking the terminal after tests complete ## Test plan - Run `npm run e2e` with and without the env var to verify behavior - Agents running e2e tests should no longer hang waiting for user input #skip-bugbot 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Stop the Playwright HTML reporter from auto-opening and blocking the terminal by setting PLAYWRIGHT_HTML_OPEN=never on all e2e commands. Updated AGENTS.md and Claude command files so local runs and agent workflows no longer hang after tests. <sup>Written for commit 2ee4139f8a43a5bc20ae1933b6c629d19c96937b. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --------- Co-authored-by: 's avatarClaude Opus 4.5 <noreply@anthropic.com>
上级 68f4de78
显示空白字符变更
内嵌 并排
正在显示 包含 14 行增加 和 8 行删除
.claude/commands/dyad/deflake-e2e.md
浏览文件 @ 7730b51e
...@@ -35,7 +35,7 @@ Identify and fix flaky E2E tests by running them repeatedly and investigating fa ...@@ -35,7 +35,7 @@ Identify and fix flaky E2E tests by running them repeatedly and investigating fa
For each test file, run it 10 times: For each test file, run it 10 times:
``` ```
npm run e2e -- e2e-tests/<testfile>.spec.ts --repeat-each=10 PLAYWRIGHT_HTML_OPEN=never npm run e2e -- e2e-tests/<testfile>.spec.ts --repeat-each=10
``` ```
Notes: Notes:
...@@ -48,7 +48,7 @@ Identify and fix flaky E2E tests by running them repeatedly and investigating fa ...@@ -48,7 +48,7 @@ Identify and fix flaky E2E tests by running them repeatedly and investigating fa
Run the failing test with Playwright browser debugging enabled: Run the failing test with Playwright browser debugging enabled:
``` ```
DEBUG=pw:browser npm run e2e -- e2e-tests/<testfile>.spec.ts DEBUG=pw:browser PLAYWRIGHT_HTML_OPEN=never npm run e2e -- e2e-tests/<testfile>.spec.ts
``` ```
Analyze the debug output to understand: Analyze the debug output to understand:
...@@ -75,7 +75,7 @@ Identify and fix flaky E2E tests by running them repeatedly and investigating fa ...@@ -75,7 +75,7 @@ Identify and fix flaky E2E tests by running them repeatedly and investigating fa
If the flakiness is due to legitimate visual differences: If the flakiness is due to legitimate visual differences:
``` ```
npm run e2e -- e2e-tests/<testfile>.spec.ts --update-snapshots PLAYWRIGHT_HTML_OPEN=never npm run e2e -- e2e-tests/<testfile>.spec.ts --update-snapshots
``` ```
8. **Verify the fix:** 8. **Verify the fix:**
...@@ -83,7 +83,7 @@ Identify and fix flaky E2E tests by running them repeatedly and investigating fa ...@@ -83,7 +83,7 @@ Identify and fix flaky E2E tests by running them repeatedly and investigating fa
Re-run the test 10 times to confirm it's no longer flaky: Re-run the test 10 times to confirm it's no longer flaky:
``` ```
npm run e2e -- e2e-tests/<testfile>.spec.ts --repeat-each=10 PLAYWRIGHT_HTML_OPEN=never npm run e2e -- e2e-tests/<testfile>.spec.ts --repeat-each=10
``` ```
The test should pass all 10 runs consistently. The test should pass all 10 runs consistently.
......
.claude/commands/dyad/e2e-rebase.md
浏览文件 @ 7730b51e
...@@ -21,13 +21,13 @@ Rebase E2E test snapshots based on failed tests from the PR comments. ...@@ -21,13 +21,13 @@ Rebase E2E test snapshots based on failed tests from the PR comments.
5. For each failed test file, run the e2e test with snapshot update: 5. For each failed test file, run the e2e test with snapshot update:
``` ```
npm run e2e e2e-tests/<testFilename>.spec.ts -- --update-snapshots PLAYWRIGHT_HTML_OPEN=never npm run e2e e2e-tests/<testFilename>.spec.ts -- --update-snapshots
``` ```
6. After updating snapshots, re-run the same tests WITHOUT `--update-snapshots` to verify they pass consistently: 6. After updating snapshots, re-run the same tests WITHOUT `--update-snapshots` to verify they pass consistently:
``` ```
npm run e2e e2e-tests/<testFilename>.spec.ts PLAYWRIGHT_HTML_OPEN=never npm run e2e e2e-tests/<testFilename>.spec.ts
``` ```
If any test fails on this verification run, inform the user that the snapshots may be flaky and stop. If any test fails on this verification run, inform the user that the snapshots may be flaky and stop.
......
.claude/commands/dyad/pr-fix/actions.md
浏览文件 @ 7730b51e
...@@ -54,7 +54,7 @@ Fix failing CI checks and GitHub Actions on a Pull Request. ...@@ -54,7 +54,7 @@ Fix failing CI checks and GitHub Actions on a Pull Request.
- If the failures are not snapshot-related: - If the failures are not snapshot-related:
- Run the failing tests locally with debug output: - Run the failing tests locally with debug output:
``` ```
DEBUG=pw:browser npm run e2e -- <test-file> DEBUG=pw:browser PLAYWRIGHT_HTML_OPEN=never npm run e2e -- <test-file>
``` ```
- Investigate and fix the underlying issues - Investigate and fix the underlying issues
......
AGENTS.md
浏览文件 @ 7730b51e
...@@ -133,10 +133,16 @@ If you would need to mock a lot of things to unit test a feature, prefer to writ ...@@ -133,10 +133,16 @@ If you would need to mock a lot of things to unit test a feature, prefer to writ
Do NOT write lots of e2e test cases for one feature. Each e2e test case adds a significant amount of overhead, so instead prefer just one or two E2E test cases that each have broad coverage of the feature in question. Do NOT write lots of e2e test cases for one feature. Each e2e test case adds a significant amount of overhead, so instead prefer just one or two E2E test cases that each have broad coverage of the feature in question.
To run e2e tests without opening the HTML report (which blocks the terminal), use:
```sh
PLAYWRIGHT_HTML_OPEN=never npm run e2e
```
To get additional debug logs when a test is failing, use: To get additional debug logs when a test is failing, use:
```sh ```sh
DEBUG=pw:browser npm run e2e DEBUG=pw:browser PLAYWRIGHT_HTML_OPEN=never npm run e2e
``` ```
## Git workflow ## Git workflow
......
Markdown 格式
0% 或
您添加了 0 人 到此讨论。请谨慎行事。
请先完成此评论的编辑！
请 注册 或者 后发表评论