提交 c0d2c635 authored 作者: Brandon T. Willard's avatar Brandon T. Willard 提交者: Ricardo Vieira

Merge CAReduce and CAReduceDtype

上级 a5626b0a
from copy import copy from copy import copy
from typing import List, Tuple, Union from typing import List, Tuple
import numpy as np import numpy as np
...@@ -1257,33 +1257,61 @@ class CAReduce(COp): ...@@ -1257,33 +1257,61 @@ class CAReduce(COp):
""" """
__props__: Union[ __props__ = ("scalar_op", "axis", "dtype", "acc_dtype", "upcast_discrete_output")
Tuple[str], Tuple[str, str], Tuple[str, str, str], Tuple[str, str, str, str]
] = ("scalar_op", "axis")
def __init__(self, scalar_op, axis=None): def __init__(
self,
scalar_op,
axis=None,
dtype=None,
acc_dtype=None,
upcast_discrete_output=False,
):
""" """
Parameters Parameters
---------- ----------
scalar_op scalar_op
A binary scalar `Op` with only one output. It must be commutative A binary scalar `Op` with only one output.
and associative. It must be commutative and associative.
axis axis
- The dimension along which we want to reduce - the dimension along which we want to reduce
- List of dimensions that we want to reduce - list of dimensions that we want to reduce
- If ``None``, all dimensions are reduced - if ``None``, all dimensions are reduced
dtype
The dtype of the returned tensor. If ``None``, then we use the default
dtype which is the same as the input array's dtype except when
`upcast_discrete_output` is ``True`` and the following holds:
- the input dtype is a signed integer of precision < 64 bit, in which
case we use int64
- the input dtype is an unsigned integer of precision < 64 bit, in
which case we use uint64
This default dtype does _not_ depend on the value of `acc_dtype`.
This behavior is similar in spirit to that of NumPy, except that
NumPy uses the default machine integer while we always use 64 bit
integers to avoid platform-dependent behavior.
acc_dtype
The dtype of the internal accumulator.
If ``None`` (default), we use the dtype in the list below,
or the input dtype if its precision is higher:
- for int dtypes, we use at least int64;
- for uint dtypes, we use at least uint64;
- for float dtypes, we use at least float64;
- for complex dtypes, we use at least complex128.
upcast_discrete_output
See
""" """
if scalar_op.nin not in (-1, 2) or scalar_op.nout != 1: if scalar_op.nin not in (-1, 2) or scalar_op.nout != 1:
raise NotImplementedError( raise NotImplementedError(
"CAReduce only supports binary functions with a single " "output." "CAReduce only supports binary functions with a single output."
) )
self.axis = None self.axis = None
self.ufunc_is_vectorized = False
self.scalar_op = scalar_op self.scalar_op = scalar_op
self.set_ufunc(scalar_op)
if axis is not None: if axis is not None:
if isinstance(axis, (int, np.integer)) or ( if isinstance(axis, (int, np.integer)) or (
...@@ -1293,64 +1321,179 @@ class CAReduce(COp): ...@@ -1293,64 +1321,179 @@ class CAReduce(COp):
else: else:
self.axis = tuple(axis) self.axis = tuple(axis)
def set_ufunc(self, scalar_op): self.dtype = dtype
if hasattr(scalar_op, "nfunc_spec") and hasattr(np, scalar_op.nfunc_spec[0]): self.acc_dtype = acc_dtype
self.ufunc = getattr(np, scalar_op.nfunc_spec[0]) self.upcast_discrete_output = upcast_discrete_output
@property
def ufunc(self):
if hasattr(self, "_ufunc"):
return self._ufunc
if hasattr(self.scalar_op, "nfunc_spec") and hasattr(
np, self.scalar_op.nfunc_spec[0]
):
self._ufunc = getattr(np, self.scalar_op.nfunc_spec[0])
else:
self._ufunc = np.frompyfunc(
self.scalar_op.impl, 2, 1, identity=self.scalar_op.identity
)
return self._ufunc
def _output_dtype(self, idtype):
if not self.upcast_discrete_output:
return idtype
dtype = self.dtype
if dtype == "OLD":
return dict(
int8="int32",
int16="int32",
int32="int64",
uint8="uint32",
uint16="uint32",
uint32="uint64",
).get(idtype, idtype)
elif dtype is None:
# If input has a discrete dtype, upcast it to 64
return dict(
bool="int64",
int8="int64",
int16="int64",
int32="int64",
uint8="uint64",
uint16="uint64",
uint32="uint64",
).get(idtype, idtype)
else: else:
self.ufunc = np.frompyfunc(scalar_op.impl, 2, 1) # The important is that the accumulator dtype does not
self.ufunc_is_vectorized = True # lose precision. Then, the result can be downcasted.
return dtype
def _output_dtype(self, input_dtype): def _acc_dtype(self, idtype):
return input_dtype acc_dtype = self.acc_dtype
if acc_dtype is None:
return dict(
bool="int64",
int8="int64",
int16="int64",
int32="int64",
uint8="uint64",
uint16="uint64",
uint32="uint64",
float16="float32",
float32="float64",
complex64="complex128",
).get(idtype, idtype)
elif acc_dtype in continuous_dtypes and idtype in discrete_dtypes:
# Specifying a continuous accumulator for discrete input is OK
return acc_dtype
else:
# The conversion has to be considered an upcast.
upcasted_dtype = upcast(idtype, acc_dtype)
if acc_dtype != upcasted_dtype:
raise TypeError(
f"Cannot build {self} node with input dtype {idtype} "
f"and acc_dtype {acc_dtype}, as precision would be lost. "
"To correct this error, you can:\n"
" - not specify acc_dtype, or\n"
f" - use an acc_dtype at least as precise as {upcasted_dtype}.\n"
' - specify "dtype" instead of "acc_dtype", so '
"the reduction will be precise, but the result will "
'be casted into "dtype" at the end.\n'
"If you are expecting the precision loss, you can "
f'use tensor.cast(..., dtype="{acc_dtype}"), on your input.'
)
return acc_dtype
def make_node(self, input): def make_node(self, input):
input = as_tensor_variable(input) input = as_tensor_variable(input)
inp_dims = input.type.ndim inp_dims = input.type.ndim
inp_dtype = input.type.dtype
# We need to redefine make_node so that, if self.dtype is None,
# we can infer what dtype should be, and create a node from an Op
# of the appropriate dtype.
dtype = self._output_dtype(inp_dtype)
acc_dtype = self._acc_dtype(inp_dtype)
assert dtype is not None
assert acc_dtype is not None
axis = self.axis axis = self.axis
if axis is None:
axis = list(range(inp_dims))
copy_op = any(a < 0 for a in axis)
# scalar inputs are treated as 1D regarding axis in this `Op` # scalar inputs are treated as 1D regarding axis in this `Op`
if axis is not None:
try: try:
axis = np.core.numeric.normalize_axis_tuple(axis, ndim=max(1, inp_dims)) axis = np.core.numeric.normalize_axis_tuple(axis, ndim=max(1, inp_dims))
except np.AxisError: except np.AxisError:
raise np.AxisError(axis, ndim=inp_dims) raise np.AxisError(axis, ndim=inp_dims)
# We can't call self.__class__() as there is a class that out_shape = tuple(
# inherits from CAReduce that doesn't have the same signature s for i, s in enumerate(input.type.shape) if i not in axis
if copy_op: )
op = copy(self)
op.set_ufunc(op.scalar_op)
assert len(axis) == len(self.axis)
op.axis = tuple(axis)
else: else:
op = self out_shape = ()
shape = [x for i, x in enumerate(input.type.shape) if i not in axis] if (
(axis is not None and any(a < 0 for a in axis))
or dtype != self.dtype
or acc_dtype != self.acc_dtype
):
op = self.clone(axis=axis, dtype=dtype, acc_dtype=acc_dtype)
else:
op = self
output = TensorType( output = TensorType(dtype=dtype, shape=out_shape)()
dtype=self._output_dtype(input.type.dtype),
shape=shape,
)()
return Apply(op, [input], [output]) return Apply(op, [input], [output])
def __getstate__(self): def clone(
d = copy(self.__dict__) self,
d.pop("ufunc", None) axis=None,
return d dtype=None,
acc_dtype=None,
upcast_discrete_output=None,
**kwargs,
):
if axis is None:
axis = self.axis
if dtype is None:
dtype = self.dtype
if acc_dtype is None:
acc_dtype = self.acc_dtype
if upcast_discrete_output is None:
upcast_discrete_output = self.upcast_discrete_output
def __setstate__(self, d): res = type(self)(
self.__dict__.update(d) self.scalar_op,
self.set_ufunc(self.scalar_op) axis=axis,
dtype=dtype,
acc_dtype=acc_dtype,
upcast_discrete_output=None,
**kwargs,
)
return res
def __str__(self): def __str__(self):
prefix = f"{type(self).__name__}{{{self.scalar_op}}}" prefix = f"{type(self).__name__}{{{self.scalar_op}}}"
extra_params = []
if self.axis is not None: if self.axis is not None:
axes_str = ", ".join(str(x) for x in self.axis) axis = ", ".join(str(x) for x in self.axis)
return f"{prefix}{{{axes_str}}}" extra_params.append(f"axis=[{axis}]")
if self.acc_dtype:
extra_params.append(f"acc_dtype={self.acc_dtype}")
extra_params_str = ", ".join(extra_params)
if extra_params_str:
return f"{prefix}{{{extra_params_str}}}"
else: else:
return f"{prefix}" return f"{prefix}"
...@@ -1358,31 +1501,21 @@ class CAReduce(COp): ...@@ -1358,31 +1501,21 @@ class CAReduce(COp):
(input,) = inp (input,) = inp
(output,) = out (output,) = out
axis = self.axis axis = self.axis
if axis is None:
axis = list(range(input.ndim))
if hasattr(self, "acc_dtype") and self.acc_dtype is not None: out_dtype = node.outputs[0].type.dtype
if self.acc_dtype is not None:
acc_dtype = self.acc_dtype acc_dtype = self.acc_dtype
else: else:
acc_dtype = node.outputs[0].type.dtype acc_dtype = out_dtype
variable = np.array(input, dtype=acc_dtype) # out_dtype = self.dtype if self.dtype and self.dtype != "OLD" else out_dtype
if axis: input = np.array(input, dtype=acc_dtype)
# Reducing functions built using np.frompyfunc() do not
# support reduction along multiple axes. Hence loop through out = self.ufunc.reduce(input, axis=axis, dtype=acc_dtype)
# each, otherwise numpy's inbuilt reduction functions
# support reduction along multiple axes directly. output[0] = _asarray(out, dtype=out_dtype)
if self.ufunc_is_vectorized:
to_reduce = reversed(sorted(axis))
for dimension in to_reduce:
variable = self.ufunc.reduce(variable, dimension, dtype=acc_dtype)
else:
variable = self.ufunc.reduce(variable, axis=tuple(axis))
output[0] = _asarray(variable, dtype=node.outputs[0].type.dtype)
else:
# Force a copy
output[0] = np.array(variable, copy=True, dtype=node.outputs[0].type.dtype)
def infer_shape(self, fgraph, node, shapes): def infer_shape(self, fgraph, node, shapes):
(ishape,) = shapes (ishape,) = shapes
...@@ -1588,176 +1721,6 @@ class CAReduce(COp): ...@@ -1588,176 +1721,6 @@ class CAReduce(COp):
return () return ()
class CAReduceDtype(CAReduce):
"""A subclass of `CAReduce` that accepts an additional output "dtype" parameter.
It also accepts an optional `acc_dtype`, which specifies the dtype that
will be used for the accumulation. The accumulation will be done using an
array of dtype `acc_dtype`, then it will be cast into `dtype` and returned.
If no `dtype` is provided, one will be inferred so as not to lose
too much precision.
"""
__props__: Union[Tuple[str, str, str], Tuple[str, str, str, str]] = (
"scalar_op",
"axis",
"dtype",
"acc_dtype",
)
def __init__(self, scalar_op, axis=None, dtype=None, acc_dtype=None):
"""
Parameters
----------
scalar_op
A binary scalar `Op` with only one output.
It must be commutative and associative.
axis
* the dimension along which we want to reduce
* list of dimensions that we want to reduce
* if ``None``, all dimensions are reduced
dtype
The dtype of the returned tensor. If ``None``, then we use the default
dtype which is the same as the input array's dtype except when:
* the input dtype is a signed integer of precision < 64 bit, in which
case we use int64
* the input dtype is an unsigned integer of precision < 64 bit, in
which case we use uint64
This default dtype does _not_ depend on the value of `acc_dtype`.
This behavior is similar in spirit to that of NumPy, except that
NumPy uses the default machine integer while we always use 64 bit
integers to avoid platform-dependent behavior.
acc_dtype
The dtype of the internal accumulator.
If ``None`` (default), we use the dtype in the list below,
or the input dtype if its precision is higher:
* for int dtypes, we use at least int64;
* for uint dtypes, we use at least uint64;
* for float dtypes, we use at least float64;
* for complex dtypes, we use at least complex128.
"""
super().__init__(scalar_op, axis=axis)
self.dtype = dtype
self.acc_dtype = acc_dtype
def __setstate__(self, d):
super().__setstate__(d)
if not hasattr(self, "dtype"):
# This is needed as old pickled will crash otherwise.
# We need to keep the old dtype behavior as the op
# could be in an apply node with a specified dtype.
self.dtype = "OLD"
if not hasattr(self, "acc_dtype"):
# acc_dtype is not used by any external Op, so we do not
# need to keep the previous behaviour here.
self.acc_dtype = None
def _output_dtype(self, idtype):
dtype = self.dtype
if dtype == "OLD":
return dict(
int8="int32",
int16="int32",
int32="int64",
uint8="uint32",
uint16="uint32",
uint32="uint64",
).get(idtype, idtype)
if dtype is None:
# If input has a discrete dtype, upcast it to 64
return dict(
bool="int64",
int8="int64",
int16="int64",
int32="int64",
uint8="uint64",
uint16="uint64",
uint32="uint64",
).get(idtype, idtype)
else:
# The important is that the accumulator dtype does not
# lose precision. Then, the result can be downcasted.
return dtype
def _acc_dtype(self, idtype):
acc_dtype = self.acc_dtype
if acc_dtype is None:
return dict(
bool="int64",
int8="int64",
int16="int64",
int32="int64",
uint8="uint64",
uint16="uint64",
uint32="uint64",
float16="float32",
float32="float64",
complex64="complex128",
).get(idtype, idtype)
elif acc_dtype in continuous_dtypes and idtype in discrete_dtypes:
# Specifying a continuous accumulator for discrete input is OK
return acc_dtype
else:
# The conversion has to be considered an upcast.
upcasted_dtype = upcast(idtype, acc_dtype)
if acc_dtype != upcasted_dtype:
raise TypeError(
f"Cannot build {self} node with input dtype {idtype} "
f"and acc_dtype {acc_dtype}, as precision would be lost. "
"To correct this error, you can:\n"
" - not specify acc_dtype, or\n"
f" - use an acc_dtype at least as precise as {upcasted_dtype}.\n"
' - specify "dtype" instead of "acc_dtype", so '
"the reduction will be precise, but the result will "
'be casted into "dtype" at the end.\n'
"If you are expecting the precision loss, you can "
f'use tensor.cast(..., dtype="{acc_dtype}"), on your input.'
)
return acc_dtype
def make_node(self, input):
# We need to redefine make_node so that, if self.dtype is None,
# we can infer what dtype should be, and create a node from an Op
# of the appropriate dtype.
input = as_tensor_variable(input)
dtype = self._output_dtype(input.dtype)
acc_dtype = self._acc_dtype(input.dtype)
assert dtype is not None
assert acc_dtype is not None
if dtype == self.dtype and acc_dtype == self.acc_dtype:
# Don't build another instance
op = self
else:
op = copy(self)
op.set_ufunc(self.scalar_op)
op.dtype = dtype
op.acc_dtype = acc_dtype
assert op.acc_dtype is not None
# TODO: Why doesn't `make_node` just take these
# automatically-determined values as arguments?
return super(CAReduceDtype, op).make_node(input)
def __str__(self):
prefix = f"{type(self).__name__}{{{self.scalar_op}}}"
if self.axis is not None:
axis = ", ".join(str(x) for x in self.axis)
return f"{prefix}{{axis=[{axis}], acc_dtype={self.acc_dtype}}}"
else:
return f"{prefix}{{acc_dtype={self.acc_dtype}}}"
def scalar_elemwise(*symbol, nfunc=None, nin=None, nout=None, symbolname=None): def scalar_elemwise(*symbol, nfunc=None, nin=None, nout=None, symbolname=None):
"""Replace a symbol definition with an `Elemwise`-wrapped version of the corresponding scalar `Op`. """Replace a symbol definition with an `Elemwise`-wrapped version of the corresponding scalar `Op`.
......
...@@ -25,13 +25,7 @@ from pytensor.tensor.basic import ( ...@@ -25,13 +25,7 @@ from pytensor.tensor.basic import (
stack, stack,
switch, switch,
) )
from pytensor.tensor.elemwise import ( from pytensor.tensor.elemwise import CAReduce, DimShuffle, Elemwise, scalar_elemwise
CAReduce,
CAReduceDtype,
DimShuffle,
Elemwise,
scalar_elemwise,
)
from pytensor.tensor.shape import shape, specify_broadcastable from pytensor.tensor.shape import shape, specify_broadcastable
from pytensor.tensor.type import ( from pytensor.tensor.type import (
DenseTensorType, DenseTensorType,
...@@ -633,6 +627,10 @@ class Max(NonZeroCAReduce): ...@@ -633,6 +627,10 @@ class Max(NonZeroCAReduce):
def __init__(self, axis): def __init__(self, axis):
super().__init__(aes.scalar_maximum, axis) super().__init__(aes.scalar_maximum, axis)
def clone(self, **kwargs):
axis = kwargs.get("axis", self.axis)
return type(self)(axis=axis)
class Min(NonZeroCAReduce): class Min(NonZeroCAReduce):
nfunc_spec = ("min", 1, 1) nfunc_spec = ("min", 1, 1)
...@@ -640,6 +638,10 @@ class Min(NonZeroCAReduce): ...@@ -640,6 +638,10 @@ class Min(NonZeroCAReduce):
def __init__(self, axis): def __init__(self, axis):
super().__init__(aes.scalar_minimum, axis) super().__init__(aes.scalar_minimum, axis)
def clone(self, **kwargs):
axis = kwargs.get("axis", self.axis)
return type(self)(axis=axis)
def max(x, axis=None, keepdims=False): def max(x, axis=None, keepdims=False):
""" """
...@@ -1530,6 +1532,10 @@ class Mean(CAReduce): ...@@ -1530,6 +1532,10 @@ class Mean(CAReduce):
""" """
) )
def clone(self, **kwargs):
axis = kwargs.get("axis", self.axis)
return type(self)(axis=axis)
# TODO: implement the grad. When done and tested, you can make this the default # TODO: implement the grad. When done and tested, you can make this the default
# version. # version.
...@@ -2350,7 +2356,6 @@ class All(CAReduce): ...@@ -2350,7 +2356,6 @@ class All(CAReduce):
""" """
__props__ = ("axis",)
nfunc_spec = ("all", 1, 1) nfunc_spec = ("all", 1, 1)
def __init__(self, axis=None): def __init__(self, axis=None):
...@@ -2376,6 +2381,10 @@ class All(CAReduce): ...@@ -2376,6 +2381,10 @@ class All(CAReduce):
(x,) = inp (x,) = inp
return [x.zeros_like(config.floatX)] return [x.zeros_like(config.floatX)]
def clone(self, **kwargs):
axis = kwargs.get("axis", self.axis)
return type(self)(axis=axis)
class Any(CAReduce): class Any(CAReduce):
"""Applies `bitwise or` to all the values of a tensor along the """Applies `bitwise or` to all the values of a tensor along the
...@@ -2383,7 +2392,6 @@ class Any(CAReduce): ...@@ -2383,7 +2392,6 @@ class Any(CAReduce):
""" """
__props__ = ("axis",)
nfunc_spec = ("any", 1, 1) nfunc_spec = ("any", 1, 1)
def __init__(self, axis=None): def __init__(self, axis=None):
...@@ -2409,48 +2417,31 @@ class Any(CAReduce): ...@@ -2409,48 +2417,31 @@ class Any(CAReduce):
(x,) = inp (x,) = inp
return [x.zeros_like(config.floatX)] return [x.zeros_like(config.floatX)]
def clone(self, **kwargs):
axis = kwargs.get("axis", self.axis)
return type(self)(axis=axis)
class Sum(CAReduceDtype): class Sum(CAReduce):
""" """
Sums all the values of a tensor along the specified axis(es). Sums all the values of a tensor along the specified axis(es).
Equivalent to `CAReduceDtype(scalar.add, axis=axis, dtype=dtype)`, Equivalent to `CAReduce(scalar.add, axis=axis, dtype=dtype)`,
with the difference that this defines the gradient of sum wrt its with the difference that this defines the gradient of sum wrt its
tensor input. tensor input.
Parameters """
----------
axis
Axis(es) along which the tensor should be summed
(use None to sum over all axes, and a list or tuple to sum along more
than one axis).
dtype
The dtype of the internal accumulator and returned
tensor. If None, then we use the default dtype which is the same as the
input tensor's dtype except when:
- the input dtype is a signed integer of precision < 64 bit, in
which case we use int64
- the input dtype is an unsigned integer of precision < 64 bit, in
which case we use uint64
This value does not depend on the value of "acc_dtype".
acc_dtype
The dtype of the internal accumulator.
If None (default), we use the dtype in the list below,
or the input dtype if its precision is higher:
- for int dtypes, we use at least int64;
- for uint dtypes, we use at least uint64;
- for float dtypes, we use at least float64;
- for complex dtypes, we use at least complex128.
"""
__props__ = ("axis", "dtype", "acc_dtype")
nfunc_spec = ("sum", 1, 1) nfunc_spec = ("sum", 1, 1)
def __init__(self, axis=None, dtype=None, acc_dtype=None): def __init__(self, axis=None, dtype=None, acc_dtype=None):
super().__init__(aes.add, axis=axis, dtype=dtype, acc_dtype=acc_dtype) super().__init__(
aes.add,
axis=axis,
dtype=dtype,
acc_dtype=acc_dtype,
upcast_discrete_output=True,
)
def __str__(self): def __str__(self):
name = self.__class__.__name__ name = self.__class__.__name__
...@@ -2492,6 +2483,12 @@ class Sum(CAReduceDtype): ...@@ -2492,6 +2483,12 @@ class Sum(CAReduceDtype):
return [None] return [None]
return self(*eval_points, return_list=True) return self(*eval_points, return_list=True)
def clone(self, **kwargs):
axis = kwargs.get("axis", self.axis)
dtype = kwargs.get("dtype", self.dtype)
acc_dtype = kwargs.get("acc_dtype", self.acc_dtype)
return type(self)(axis=axis, dtype=dtype, acc_dtype=acc_dtype)
def sum(input, axis=None, dtype=None, keepdims=False, acc_dtype=None): def sum(input, axis=None, dtype=None, keepdims=False, acc_dtype=None):
""" """
...@@ -2523,7 +2520,7 @@ def sum(input, axis=None, dtype=None, keepdims=False, acc_dtype=None): ...@@ -2523,7 +2520,7 @@ def sum(input, axis=None, dtype=None, keepdims=False, acc_dtype=None):
pprint.assign(Sum, printing.FunctionPrinter(["sum"], ["axis"])) pprint.assign(Sum, printing.FunctionPrinter(["sum"], ["axis"]))
class Prod(CAReduceDtype): class Prod(CAReduce):
""" """
Multiplies all the values of a tensor along the specified axis(es). Multiplies all the values of a tensor along the specified axis(es).
...@@ -2533,19 +2530,20 @@ class Prod(CAReduceDtype): ...@@ -2533,19 +2530,20 @@ class Prod(CAReduceDtype):
""" """
__props__ = ("axis", "dtype", "acc_dtype") __props__ = ("scalar_op", "axis", "dtype", "acc_dtype", "no_zeros_in_input")
nfunc_spec = ("prod", 1, 1) nfunc_spec = ("prod", 1, 1)
def __init__(self, axis=None, dtype=None, acc_dtype=None, no_zeros_in_input=False): def __init__(self, axis=None, dtype=None, acc_dtype=None, no_zeros_in_input=False):
super().__init__(aes.mul, axis=axis, dtype=dtype, acc_dtype=acc_dtype) super().__init__(
aes.mul,
axis=axis,
dtype=dtype,
acc_dtype=acc_dtype,
upcast_discrete_output=True,
)
self.no_zeros_in_input = no_zeros_in_input self.no_zeros_in_input = no_zeros_in_input
def __setstate__(self, dct):
super().__setstate__(dct)
# Add default value to be able to reload old pickled objects.
if "no_zeros_in_input" not in dct:
self.no_zeros_in_input = False
def L_op(self, inp, out, grads): def L_op(self, inp, out, grads):
""" """
The grad of this Op could be very easy, if it is was not for the case The grad of this Op could be very easy, if it is was not for the case
...@@ -2668,6 +2666,18 @@ class Prod(CAReduceDtype): ...@@ -2668,6 +2666,18 @@ class Prod(CAReduceDtype):
def c_code_cache_version(self): def c_code_cache_version(self):
return (1,) return (1,)
def clone(self, **kwargs):
axis = kwargs.get("axis", self.axis)
dtype = kwargs.get("dtype", self.dtype)
acc_dtype = kwargs.get("acc_dtype", self.acc_dtype)
no_zeros_in_input = kwargs.get("no_zeros_in_input", self.no_zeros_in_input)
return type(self)(
axis=axis,
dtype=dtype,
acc_dtype=acc_dtype,
no_zeros_in_input=no_zeros_in_input,
)
def prod( def prod(
input, input,
...@@ -2736,12 +2746,15 @@ class MulWithoutZeros(BinaryScalarOp): ...@@ -2736,12 +2746,15 @@ class MulWithoutZeros(BinaryScalarOp):
mul_without_zeros = MulWithoutZeros(aes.upcast_out, name="mul_without_zeros") mul_without_zeros = MulWithoutZeros(aes.upcast_out, name="mul_without_zeros")
class ProdWithoutZeros(CAReduceDtype): class ProdWithoutZeros(CAReduce):
__props__ = ("axis", "dtype", "acc_dtype")
def __init__(self, axis=None, dtype=None, acc_dtype=None): def __init__(self, axis=None, dtype=None, acc_dtype=None):
super().__init__(mul_without_zeros, axis=axis, dtype=dtype, acc_dtype=acc_dtype) super().__init__(
mul_without_zeros,
axis=axis,
dtype=dtype,
acc_dtype=acc_dtype,
upcast_discrete_output=True,
)
def grad(self, inp, grads): def grad(self, inp, grads):
from pytensor.gradient import grad_not_implemented from pytensor.gradient import grad_not_implemented
...@@ -2757,6 +2770,12 @@ class ProdWithoutZeros(CAReduceDtype): ...@@ -2757,6 +2770,12 @@ class ProdWithoutZeros(CAReduceDtype):
) )
return [a_grad] return [a_grad]
def clone(self, **kwargs):
axis = kwargs.get("axis", self.axis)
dtype = kwargs.get("dtype", self.dtype)
acc_dtype = kwargs.get("acc_dtype", self.acc_dtype)
return type(self)(axis=axis, dtype=dtype, acc_dtype=acc_dtype)
def any(x, axis=None, keepdims=False): def any(x, axis=None, keepdims=False):
out = Any(axis)(x) out = Any(axis)(x)
......
...@@ -17,7 +17,7 @@ from pytensor.link.basic import PerformLinker ...@@ -17,7 +17,7 @@ from pytensor.link.basic import PerformLinker
from pytensor.link.c.basic import CLinker, OpWiseCLinker from pytensor.link.c.basic import CLinker, OpWiseCLinker
from pytensor.tensor import as_tensor_variable from pytensor.tensor import as_tensor_variable
from pytensor.tensor.basic import second from pytensor.tensor.basic import second
from pytensor.tensor.elemwise import CAReduce, CAReduceDtype, DimShuffle, Elemwise from pytensor.tensor.elemwise import CAReduce, DimShuffle, Elemwise
from pytensor.tensor.exceptions import ShapeError from pytensor.tensor.exceptions import ShapeError
from pytensor.tensor.math import all as at_all from pytensor.tensor.math import all as at_all
from pytensor.tensor.math import any as at_any from pytensor.tensor.math import any as at_any
...@@ -537,24 +537,16 @@ class TestCAReduce(unittest_tools.InferShapeTester): ...@@ -537,24 +537,16 @@ class TestCAReduce(unittest_tools.InferShapeTester):
for axis in reversed(sorted(tosum)): for axis in reversed(sorted(tosum)):
zv = np.bitwise_xor.reduce(zv, axis) zv = np.bitwise_xor.reduce(zv, axis)
else: else:
raise Exception( raise NotImplementedError(
f"Test for CAReduce with scalar_op {scalar_op} not implemented" f"Test for CAReduce with scalar_op {scalar_op} not implemented"
) )
if test_nan: if test_nan:
try:
assert self.type.values_eq(f(xv), zv), (f(xv), zv) assert self.type.values_eq(f(xv), zv), (f(xv), zv)
except NotImplementedError:
# GpuCAReduce don't implement all cases when size is 0
assert xv.size == 0
else: else:
try:
f_xv = f(xv) f_xv = f(xv)
assert f_xv.shape == zv.shape, (f_xv, zv) assert f_xv.shape == zv.shape, (f_xv, zv)
utt.assert_allclose(zv, f_xv) utt.assert_allclose(zv, f_xv)
except NotImplementedError:
# GpuCAReduce don't implement all cases when size is 0
assert xv.size == 0
x = self.type( x = self.type(
dtype, shape=tuple(entry if entry == 1 else None for entry in xsh) dtype, shape=tuple(entry if entry == 1 else None for entry in xsh)
...@@ -570,11 +562,7 @@ class TestCAReduce(unittest_tools.InferShapeTester): ...@@ -570,11 +562,7 @@ class TestCAReduce(unittest_tools.InferShapeTester):
scalar_op in [aes.scalar_maximum, aes.scalar_minimum] scalar_op in [aes.scalar_maximum, aes.scalar_minimum]
and (xsh == () or np.prod(xsh) == 0) and (xsh == () or np.prod(xsh) == 0)
): ):
try:
assert all(f(xv) == zv.shape) assert all(f(xv) == zv.shape)
except NotImplementedError:
# GpuCAReduce don't implement all cases when size is 0
assert xv.size == 0
def test_perform_noopt(self): def test_perform_noopt(self):
self.with_mode(Mode(linker="py", optimizer=None), aes.add, dtype="floatX") self.with_mode(Mode(linker="py", optimizer=None), aes.add, dtype="floatX")
...@@ -691,12 +679,12 @@ class TestCAReduce(unittest_tools.InferShapeTester): ...@@ -691,12 +679,12 @@ class TestCAReduce(unittest_tools.InferShapeTester):
op = CAReduce(aes.add, axis=None) op = CAReduce(aes.add, axis=None)
assert str(op) == "CAReduce{add}" assert str(op) == "CAReduce{add}"
op = CAReduce(aes.add, axis=(1,)) op = CAReduce(aes.add, axis=(1,))
assert str(op) == "CAReduce{add}{1}" assert str(op) == "CAReduce{add}{axis=[1]}"
op = CAReduceDtype(aes.add, axis=None, acc_dtype="float64") op = CAReduce(aes.add, axis=None, acc_dtype="float64")
assert str(op) == "CAReduceDtype{add}{acc_dtype=float64}" assert str(op) == "CAReduce{add}{acc_dtype=float64}"
op = CAReduceDtype(aes.add, axis=(1,), acc_dtype="float64") op = CAReduce(aes.add, axis=(1,), acc_dtype="float64")
assert str(op) == "CAReduceDtype{add}{axis=[1], acc_dtype=float64}" assert str(op) == "CAReduce{add}{axis=[1], acc_dtype=float64}"
def test_repeated_axis(self): def test_repeated_axis(self):
x = vector("x") x = vector("x")
......
Markdown 格式
0%
您添加了 0 到此讨论。请谨慎行事。
请先完成此评论的编辑!
注册 或者 后发表评论