Merge pull request #1343 from lamblin/fix_rebuild_strict

theano/compile/pfunc.py

@@ -479,7 +479,7 @@ def pfunc(params, outputs=None, mode=None, updates=None, givens=None,
                                          in_variables,
                                          replace=givens,
                                          updates=updates,
-                                         rebuild_strict=True,
+                                         rebuild_strict=rebuild_strict,
                                          copy_inputs_over=True,
                                          no_default_updates=no_default_updates)
     # extracting the arguments

theano/compile/tests/test_pfunc.py

@@ -985,6 +985,19 @@ class Test_aliasing_rules(unittest.TestCase):
             # objects forming a chain to the underlying data.
 
 
+class Test_rebuild_strict(unittest.TestCase):
+    def test1(self):
+        # Test fix for error reported at
+        # https://groups.google.com/d/topic/theano-users/BRK0UEB72XA/discussion
+        w = tensor.imatrix()
+        x, y = tensor.ivectors('x', 'y')
+        z = x * y
+        f = theano.function([w, y], z, givens=[(x, w)], rebuild_strict=False)
+        z_val = f(numpy.ones((3, 5), dtype='int32'), numpy.arange(5, dtype='int32'))
+        assert z_val.ndim == 2
+        assert numpy.all(z_val == numpy.ones((3, 5)) * numpy.arange(5))
+
+
 if __name__ == '__main__':
     theano.config.mode = 'FAST_COMPILE'
     Test_pfunc().test_default_scalar_container()