提交 672dd1f0 authored 作者: Pascal Lamblin's avatar Pascal Lamblin

Do not print deprecation warning when the behavior does not change.

This concerns, max, argmax, min and argmin. The case where ndim==1 was handled, but not ndim==0.
上级 e46fa9ab
...@@ -1599,6 +1599,9 @@ class MaxAndArgmax(Op): ...@@ -1599,6 +1599,9 @@ class MaxAndArgmax(Op):
def make_node(self, x, axis='DEFAULT'): def make_node(self, x, axis='DEFAULT'):
x = _as_tensor_variable(x) x = _as_tensor_variable(x)
if x.type.ndim <= 1 and axis in ('DEFAULT', None):
# The old and new behavior are not different.
axis = 0
if axis=='DEFAULT': if axis=='DEFAULT':
axis=x.type.ndim - 1 axis=x.type.ndim - 1
warnings.warn("The default axis of MaxAndArgmax will change! Now we return the max and the armax over the last dimensions. It will change to be the same as numpy: the max and argmax over all dimensions. To hide this warning and be compatible with the future behavior, set axis to -1 to have the current behavior. MaxAndArgmax currently support axis over only 1 dimensions, so you must flatten the tensor to have the futur behavior.") warnings.warn("The default axis of MaxAndArgmax will change! Now we return the max and the armax over the last dimensions. It will change to be the same as numpy: the max and argmax over all dimensions. To hide this warning and be compatible with the future behavior, set axis to -1 to have the current behavior. MaxAndArgmax currently support axis over only 1 dimensions, so you must flatten the tensor to have the futur behavior.")
...@@ -1676,7 +1679,7 @@ def max(x, axis='DEFAULT'): ...@@ -1676,7 +1679,7 @@ def max(x, axis='DEFAULT'):
:note: we return an error as numpy when we reduce a dim with a shape of 0 :note: we return an error as numpy when we reduce a dim with a shape of 0
:note2: see MaxAndArgmax note for a difference between numpy and theano when axis==None :note2: see MaxAndArgmax note for a difference between numpy and theano when axis==None
""" """
if x.type.ndim == 1 and axis in ('DEFAULT', None): if x.type.ndim <= 1 and axis in ('DEFAULT', None):
# The old and new behavior are not different. # The old and new behavior are not different.
axis = 0 axis = 0
elif axis=='DEFAULT': elif axis=='DEFAULT':
...@@ -1700,7 +1703,7 @@ def argmax(x, axis='DEFAULT'): ...@@ -1700,7 +1703,7 @@ def argmax(x, axis='DEFAULT'):
Default axis is the last one. This will change. Default axis is the last one. This will change.
""" """
if x.type.ndim == 1 and axis in ('DEFAULT', None): if x.type.ndim <= 1 and axis in ('DEFAULT', None):
# The old and new behavior are not different. # The old and new behavior are not different.
axis = 0 axis = 0
elif axis=='DEFAULT': elif axis=='DEFAULT':
...@@ -1716,7 +1719,7 @@ def argmax(x, axis='DEFAULT'): ...@@ -1716,7 +1719,7 @@ def argmax(x, axis='DEFAULT'):
@constructor @constructor
def min(x, axis='DEFAULT'): def min(x, axis='DEFAULT'):
if x.type.ndim == 1 and axis in ('DEFAULT', None): if x.type.ndim <= 1 and axis in ('DEFAULT', None):
# The old and new behavior are not different. # The old and new behavior are not different.
axis = 0 axis = 0
elif axis=='DEFAULT': elif axis=='DEFAULT':
...@@ -1734,7 +1737,7 @@ def min(x, axis='DEFAULT'): ...@@ -1734,7 +1737,7 @@ def min(x, axis='DEFAULT'):
@constructor @constructor
def argmin(x, axis='DEFAULT'): def argmin(x, axis='DEFAULT'):
if x.type.ndim == 1 and axis in ('DEFAULT', None): if x.type.ndim <= 1 and axis in ('DEFAULT', None):
# The old and new behavior are not different. # The old and new behavior are not different.
axis = 0 axis = 0
elif axis=='DEFAULT': elif axis=='DEFAULT':
......
Markdown 格式
0%
您添加了 0 到此讨论。请谨慎行事。
请先完成此评论的编辑!
注册 或者 后发表评论