Update magma eigh to use params

theano/gpuarray/linalg.py

@@ -638,7 +638,12 @@ class GpuMagmaEigh(GpuMagmaBase):
     compute_v : If `True`, computes eigenvalues and eigenvectors (`True`,
                 default). If `False`, computes only eigenvalues of matrix.
     """
-    __props__ = ('lower', )
+    __props__ = ('lower', 'compute_v')
+    _cop_num_inputs = 1
+    _cop_num_outputs = 2
+    check_input = False
+    params_type = ParamsType(lower=bool_t, compute_v=bool_t,
+                             context=gpu_context_type)
 
     def __init__(self, UPLO='L', compute_v=True):
         assert UPLO in ['L', 'U']
@@ -656,18 +661,15 @@ class GpuMagmaEigh(GpuMagmaBase):
             raise TypeError("only `float32` is supported for now")
         if self.compute_v:
             return theano.Apply(self, [A],
+                                # return D, V
                                 [GpuArrayType(A.dtype, broadcastable=[False],
                                               context_name=ctx_name)(),
                                 A.type()])
         else:
             return theano.Apply(self, [A],
+                                # return D
                                 [GpuArrayType(A.dtype, broadcastable=[False],
                                               context_name=ctx_name)()])
 
-    def get_op_params(self):
-        params = []
-        if self.lower:
-            params.append(('LOWER', '1'))
-        if self.compute_v:
-            params.append(('COMPUTE_V', '1'))
-        return params
+    def get_params(self, node):
+        return self.params_type.get_params(self, context=node.inputs[0].type.context)

theano/gpuarray/magma_cholesky.c

@@ -39,7 +39,7 @@ setup_ext_cuda();
 #section support_code_struct
 
 int APPLY_SPECIFIC(magma_cholesky)(PyGpuArrayObject *A, PyGpuArrayObject **L,
-                                   PARAMS_TYPE* params) {
+                                   PARAMS_TYPE *params) {
   const size_t *dims;
   size_t N, n2;
   magma_uplo_t ul;

theano/gpuarray/magma_eigh.c

@@ -6,10 +6,8 @@ setup_ext_cuda();
 
 int APPLY_SPECIFIC(magma_eigh)(PyGpuArrayObject *A_,
                                PyGpuArrayObject **D,
-#ifdef COMPUTE_V
-                               PyGpuArrayObject **V,
-#endif
-                               PyGpuContextObject *c) {
+                               PyGpuArrayObject **V, // may be NULL
+                               PARAMS_TYPE *params) {
   PyGpuArrayObject *A = NULL;
   magma_int_t N, liwork, *iwork_data = NULL;
   size_t d_dims[1], v_dims[2];
@@ -23,21 +21,26 @@ int APPLY_SPECIFIC(magma_eigh)(PyGpuArrayObject *A_,
                     "GpuMagmaEigh: Unsupported data type");
     return -1;
   }
+
+  // This is early to match the exit() in the fail label.
+  cuda_enter(params->context->ctx);
+
   if (!GpuArray_IS_C_CONTIGUOUS(&A_->ga)) {
     PyErr_SetString(PyExc_ValueError,
                     "GpuMagmaEigh: requires data to be C-contiguous");
-    return -1;
+    goto fail;
   }
   if (PyGpuArray_NDIM(A_) != 2) {
     PyErr_SetString(PyExc_ValueError,
                     "GpuMagmaEigh: matrix rank error");
-    return -1;
+    goto fail;
   }
   if (PyGpuArray_DIM(A_, 0) != PyGpuArray_DIM(A_, 1)) {
     PyErr_SetString(PyExc_ValueError,
                     "GpuMagmaEigh: matrix is not square");
-    return -1;
+    goto fail;
   }
+
   A = pygpu_copy(A_, GA_F_ORDER);
   if (A == NULL) {
     PyErr_SetString(PyExc_RuntimeError,
@@ -45,22 +48,19 @@ int APPLY_SPECIFIC(magma_eigh)(PyGpuArrayObject *A_,
     return -1;
   }
 
-  // This is early to match the exit() in the fail label.
-  cuda_enter(c->ctx);
-
   // magma matrix eigen decomposition of a symmetric matrix
   N = PyGpuArray_DIM(A, 0);
 
-#ifdef LOWER
+  if (params->lower) {
     uplo = MagmaLower;
-#else
+  } else {
     uplo = MagmaUpper;
-#endif
-#ifdef COMPUTE_V
+  }
+  if (params->compute_v) {
     jobz = MagmaVec;
-#else
+  } else {
     jobz = MagmaNoVec;
-#endif
+  }
 
   if (MAGMA_SUCCESS != magma_smalloc_pinned(&w_data, N)) {
     PyErr_SetString(PyExc_RuntimeError,
@@ -105,7 +105,7 @@ int APPLY_SPECIFIC(magma_eigh)(PyGpuArrayObject *A_,
   }
 
   d_dims[0] = N;
-  if (theano_prep_output(D, 1, d_dims, A->ga.typecode, GA_C_ORDER, c) != 0){
+  if (theano_prep_output(D, 1, d_dims, A->ga.typecode, GA_C_ORDER, params->context) != 0){
     PyErr_SetString(PyExc_RuntimeError,
                     "GpuMagmaEigh: failed to allocate memory for the output");
     goto fail;
@@ -113,15 +113,14 @@ int APPLY_SPECIFIC(magma_eigh)(PyGpuArrayObject *A_,
   cudaMemcpy(PyGpuArray_DEV_DATA(*D), w_data, N * sizeof(float),
              cudaMemcpyDeviceToDevice);
 
-#ifdef COMPUTE_V
+  if (params->compute_v) {
     *V = theano_try_copy(*V, A);
     if (*V == NULL) {
       PyErr_SetString(PyExc_RuntimeError,
                       "GpuMagmaEigh: failed to allocate memory for the output");
       goto fail;
     }
-#endif
-
+  }
   res = 0;
 fail:
   if (w_data != NULL)
@@ -133,6 +132,6 @@ fail:
   if (iwork_data != NULL)
     magma_free_cpu(iwork_data);
   Py_XDECREF(A);
-  cuda_exit(c->ctx);
+  cuda_exit(params->context->ctx);
   return res;
 }

theano/gpuarray/magma_inv.c

@@ -5,7 +5,7 @@ setup_ext_cuda();
 #section support_code_struct
 
 int APPLY_SPECIFIC(magma_inv)(PyGpuArrayObject *A, PyGpuArrayObject **A_inv,
-                              PARAMS_TYPE* params) {
+                              PARAMS_TYPE *params) {
   const size_t *dims;
   magma_int_t N, ldwork, info;
   magma_int_t *piv = NULL;

theano/gpuarray/magma_qr.c

@@ -49,11 +49,6 @@ int APPLY_SPECIFIC(magma_qr)(PyGpuArrayObject *A_,
                     "GpuMagmaQR: Unsupported data type");
     return -1;
   }
-  if (!GpuArray_IS_C_CONTIGUOUS(&A->ga)) {
-    PyErr_SetString(PyExc_ValueError,
-                    "GpuMagmaQR: requires data to be C-contiguous");
-    return -1;
-  }
 
   // This is early to match the exit() in the fail label.
   cuda_enter(params->context->ctx);

theano/gpuarray/magma_svd.c

@@ -8,7 +8,7 @@ int APPLY_SPECIFIC(magma_svd)(PyGpuArrayObject *A,
                               PyGpuArrayObject **S,
                               PyGpuArrayObject **U, // may be NULL
                               PyGpuArrayObject **VT, // may be NULL
-                              PARAMS_TYPE* params) {
+                              PARAMS_TYPE *params) {
   bool compute_uv = (U != NULL);
   magma_int_t *iwork = NULL, iunused[1];
   magma_int_t M, N, K, ldu, ldv, M_U, N_VT, info;